Re: [PATCH 2/4] mfd: twl6040: fix error return code

2014-08-21 Thread Lee Jones
On Wed, 06 Aug 2014, Julia Lawall wrote: > From: Julia Lawall > > Convert a zero return value on error to a negative one, as returned > elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > ( >

[PATCH 2/4] mfd: twl6040: fix error return code

2014-08-06 Thread Julia Lawall
From: Julia Lawall Convert a zero return value on error to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0