Re: [PATCH 2/4] oom: Do not invoke oom notifiers on sysrq+f

2015-07-15 Thread David Rientjes
On Wed, 15 Jul 2015, Michal Hocko wrote: > > > Shrinkers are there to reclaim and prevent from OOM. This API is a gray > > > zone. It looks generic method for the notification yet it allows to > > > prevent from oom killer. I can imagine somebody might abuse this > > > interface to implement OOM k

Re: [PATCH 2/4] oom: Do not invoke oom notifiers on sysrq+f

2015-07-15 Thread Michal Hocko
On Tue 14-07-15 14:58:55, David Rientjes wrote: > On Fri, 10 Jul 2015, Michal Hocko wrote: > > > Shrinkers are there to reclaim and prevent from OOM. This API is a gray > > zone. It looks generic method for the notification yet it allows to > > prevent from oom killer. I can imagine somebody might

Re: [PATCH 2/4] oom: Do not invoke oom notifiers on sysrq+f

2015-07-14 Thread David Rientjes
On Fri, 10 Jul 2015, Michal Hocko wrote: > Shrinkers are there to reclaim and prevent from OOM. This API is a gray > zone. It looks generic method for the notification yet it allows to > prevent from oom killer. I can imagine somebody might abuse this > interface to implement OOM killer policies.

Re: [PATCH 2/4] oom: Do not invoke oom notifiers on sysrq+f

2015-07-10 Thread Michal Hocko
On Thu 09-07-15 14:07:37, David Rientjes wrote: > On Thu, 9 Jul 2015, Michal Hocko wrote: [...] > > So I am not > > sure it belongs outside of the oom killer proper. > > > > Umm it has nothing to do with oom killing, it quite obviously doesn't > belong in the oom killer. The naming of the API w

Re: [PATCH 2/4] oom: Do not invoke oom notifiers on sysrq+f

2015-07-09 Thread David Rientjes
On Thu, 9 Jul 2015, Michal Hocko wrote: > > Nack, the oom notify list has no place in the oom killer, it should be > > called in the page allocator before calling out_of_memory(). > > I cannot say I would like oom notifiers interface. Quite contrary, it is > just a crude hack. It is living out

Re: [PATCH 2/4] oom: Do not invoke oom notifiers on sysrq+f

2015-07-09 Thread Michal Hocko
On Wed 08-07-15 16:37:49, David Rientjes wrote: > On Wed, 8 Jul 2015, Michal Hocko wrote: > > > From: Michal Hocko > > > > A github user rfjakob has reported the following issue via IRC. > > Manually triggering the OOM killer does not work anymore in 4.0.5 > > This is what it looks like: > >

Re: [PATCH 2/4] oom: Do not invoke oom notifiers on sysrq+f

2015-07-08 Thread David Rientjes
On Wed, 8 Jul 2015, Michal Hocko wrote: > From: Michal Hocko > > A github user rfjakob has reported the following issue via IRC. > Manually triggering the OOM killer does not work anymore in 4.0.5 > This is what it looks like: > https://gist.github.com/rfjakob/346b7dc611fc3cdf4011 > Basicall

[PATCH 2/4] oom: Do not invoke oom notifiers on sysrq+f

2015-07-08 Thread Michal Hocko
From: Michal Hocko A github user rfjakob has reported the following issue via IRC. Manually triggering the OOM killer does not work anymore in 4.0.5 This is what it looks like: https://gist.github.com/rfjakob/346b7dc611fc3cdf4011 Basically, what happens is that the GPU driver frees some memor