Re: [PATCH 2/4] perf stat: Add --for-each-cgroup option

2020-09-20 Thread Namhyung Kim
On Fri, Sep 18, 2020 at 10:34 PM Jiri Olsa wrote: > > On Wed, Sep 16, 2020 at 03:31:27PM +0900, Namhyung Kim wrote: > > SNIP > > > +int evlist__expand_cgroup(struct evlist *evlist, const char *str) > > +{ > > + struct evlist *orig_list, *tmp_list; > > + struct evsel *pos, *evsel, *leader;

Re: [PATCH 2/4] perf stat: Add --for-each-cgroup option

2020-09-18 Thread Jiri Olsa
On Wed, Sep 16, 2020 at 03:31:27PM +0900, Namhyung Kim wrote: SNIP > +int evlist__expand_cgroup(struct evlist *evlist, const char *str) > +{ > + struct evlist *orig_list, *tmp_list; > + struct evsel *pos, *evsel, *leader; > + struct cgroup *cgrp = NULL; > + const char *p, *e, *eos

Re: [PATCH 2/4] perf stat: Add --for-each-cgroup option

2020-09-16 Thread Namhyung Kim
On Wed, Sep 16, 2020 at 10:51 PM Arnaldo Carvalho de Melo wrote: > > Em Wed, Sep 16, 2020 at 03:31:27PM +0900, Namhyung Kim escreveu: > > The --for-each-cgroup option is a syntax sugar to monitor large number > > You forgot to add the man page entry for this new option. OK, will add.. any more co

Re: [PATCH 2/4] perf stat: Add --for-each-cgroup option

2020-09-16 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 16, 2020 at 03:31:27PM +0900, Namhyung Kim escreveu: > The --for-each-cgroup option is a syntax sugar to monitor large number You forgot to add the man page entry for this new option. - Arnaldo > of cgroups easily. Current command line requires to list all the > events and cgroups e

[PATCH 2/4] perf stat: Add --for-each-cgroup option

2020-09-15 Thread Namhyung Kim
The --for-each-cgroup option is a syntax sugar to monitor large number of cgroups easily. Current command line requires to list all the events and cgroups even if users want to monitor same events for each cgroup. This patch addresses that usage by copying given events for each cgroup on user's b