Re: [PATCH 2/4] regulator: core: Expose init_data to of_parse_cb

2015-03-04 Thread Mark Brown
On Tue, Mar 03, 2015 at 08:15:41AM -0800, Bjorn Andersson wrote: > On Tue 03 Mar 04:50 PST 2015, Mark Brown wrote: > > Why would the driver need to do that? I guess I'll see later on in the > > series but the changelog should make that clear. Drivers aren't > > supposed to ever need to look at

Re: [PATCH 2/4] regulator: core: Expose init_data to of_parse_cb

2015-03-04 Thread Mark Brown
On Tue, Mar 03, 2015 at 08:15:41AM -0800, Bjorn Andersson wrote: On Tue 03 Mar 04:50 PST 2015, Mark Brown wrote: Why would the driver need to do that? I guess I'll see later on in the series but the changelog should make that clear. Drivers aren't supposed to ever need to look at their

Re: [PATCH 2/4] regulator: core: Expose init_data to of_parse_cb

2015-03-03 Thread Bjorn Andersson
On Tue 03 Mar 04:50 PST 2015, Mark Brown wrote: > On Mon, Mar 02, 2015 at 08:25:38PM -0800, Bjorn Andersson wrote: > > > Expose the newly created init_data to the driver's parse callback so > > that it can futher enhance it with e.g. constraints of the regulator. > > Why would the driver need

Re: [PATCH 2/4] regulator: core: Expose init_data to of_parse_cb

2015-03-03 Thread Mark Brown
On Mon, Mar 02, 2015 at 08:25:38PM -0800, Bjorn Andersson wrote: > Expose the newly created init_data to the driver's parse callback so > that it can futher enhance it with e.g. constraints of the regulator. Why would the driver need to do that? I guess I'll see later on in the series but the

[PATCH 2/4] regulator: core: Expose init_data to of_parse_cb

2015-03-03 Thread Bjorn Andersson
Expose the newly created init_data to the driver's parse callback so that it can futher enhance it with e.g. constraints of the regulator. Signed-off-by: Bjorn Andersson --- This is needed because calling regulator_register() with a of_node and of_match will overwrite the passed

Re: [PATCH 2/4] regulator: core: Expose init_data to of_parse_cb

2015-03-03 Thread Mark Brown
On Mon, Mar 02, 2015 at 08:25:38PM -0800, Bjorn Andersson wrote: Expose the newly created init_data to the driver's parse callback so that it can futher enhance it with e.g. constraints of the regulator. Why would the driver need to do that? I guess I'll see later on in the series but the

Re: [PATCH 2/4] regulator: core: Expose init_data to of_parse_cb

2015-03-03 Thread Bjorn Andersson
On Tue 03 Mar 04:50 PST 2015, Mark Brown wrote: On Mon, Mar 02, 2015 at 08:25:38PM -0800, Bjorn Andersson wrote: Expose the newly created init_data to the driver's parse callback so that it can futher enhance it with e.g. constraints of the regulator. Why would the driver need to do

[PATCH 2/4] regulator: core: Expose init_data to of_parse_cb

2015-03-03 Thread Bjorn Andersson
Expose the newly created init_data to the driver's parse callback so that it can futher enhance it with e.g. constraints of the regulator. Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com --- This is needed because calling regulator_register() with a of_node and of_match will