Re: [PATCH 2/4] staging/lustre/obdclass: read jobid from proc

2014-02-04 Thread Oleg Drokin
Hello! On Feb 4, 2014, at 11:57 AM, Greg Kroah-Hartman wrote: > What exactly are you doing here? Calling out to userspace for what > information? And how are you going to handle namespaces and containers > by doing that? Are you going to block in the kernel for this > information? > > What ar

Re: [PATCH 2/4] staging/lustre/obdclass: read jobid from proc

2014-02-04 Thread Greg Kroah-Hartman
On Tue, Feb 04, 2014 at 10:12:10AM +0400, Oleg Drokin wrote: > Hello! > > On Wed, Oct 30, 2013 at 06:21:01AM -0700, Greg Kroah-Hartman wrote: > > > - * stored in between the "env_start" & "env_end" of task struct. > > > +static char *self_environ_file = "/proc/self/environ"; > > > > Heh, no, that

Re: [PATCH 2/4] staging/lustre/obdclass: read jobid from proc

2014-02-03 Thread Oleg Drokin
Hello! On Wed, Oct 30, 2013 at 06:21:01AM -0700, Greg Kroah-Hartman wrote: > > - * stored in between the "env_start" & "env_end" of task struct. > > +static char *self_environ_file = "/proc/self/environ"; > > Heh, no, that's not ok at all. > > This is a _huge_ sign that you are doing something w

Re: [PATCH 2/4] staging/lustre/obdclass: read jobid from proc

2013-10-30 Thread Peng Tao
On Wed, Oct 30, 2013 at 10:20 PM, Greg Kroah-Hartman wrote: > On Wed, Oct 30, 2013 at 09:31:24PM +0800, Peng Tao wrote: >> On Wed, Oct 30, 2013 at 9:21 PM, Greg Kroah-Hartman >> wrote: >> > On Wed, Oct 30, 2013 at 07:30:34PM +0800, Peng Tao wrote: >> >> so that we can get rid of cfs_get_environ()

Re: [PATCH 2/4] staging/lustre/obdclass: read jobid from proc

2013-10-30 Thread Greg Kroah-Hartman
On Wed, Oct 30, 2013 at 09:31:24PM +0800, Peng Tao wrote: > On Wed, Oct 30, 2013 at 9:21 PM, Greg Kroah-Hartman > wrote: > > On Wed, Oct 30, 2013 at 07:30:34PM +0800, Peng Tao wrote: > >> so that we can get rid of cfs_get_environ() that needs access_process_vm() > >> that > >> is a core mm functi

Re: [PATCH 2/4] staging/lustre/obdclass: read jobid from proc

2013-10-30 Thread Peng Tao
On Wed, Oct 30, 2013 at 9:21 PM, Greg Kroah-Hartman wrote: > On Wed, Oct 30, 2013 at 07:30:34PM +0800, Peng Tao wrote: >> so that we can get rid of cfs_get_environ() that needs access_process_vm() >> that >> is a core mm function and is not available on some architectures. >> >> Reviewed-by: Niu

Re: [PATCH 2/4] staging/lustre/obdclass: read jobid from proc

2013-10-30 Thread Greg Kroah-Hartman
On Wed, Oct 30, 2013 at 07:30:34PM +0800, Peng Tao wrote: > so that we can get rid of cfs_get_environ() that needs access_process_vm() > that > is a core mm function and is not available on some architectures. > > Reviewed-by: Niu Yawei > Signed-off-by: Peng Tao > Signed-off-by: Andreas Dilger

[PATCH 2/4] staging/lustre/obdclass: read jobid from proc

2013-10-30 Thread Peng Tao
so that we can get rid of cfs_get_environ() that needs access_process_vm() that is a core mm function and is not available on some architectures. Reviewed-by: Niu Yawei Signed-off-by: Peng Tao Signed-off-by: Andreas Dilger --- drivers/staging/lustre/lustre/obdclass/class_obd.c | 119 +