Re: [PATCH 2/4] uprobes: Fully initialize uprobe_trace_consumer before uprobe_register()

2013-01-28 Thread Srikar Dronamraju
* Oleg Nesterov [2013-01-27 20:48:37]: > probe_event_enable() does uprobe_register() and only after that sets > utc->tu and tu->consumer/flags. This can race with uprobe_dispatcher() > which can miss these assignments or see them out of order. Nothing > really bad can happen, but this doesn't

Re: [PATCH 2/4] uprobes: Fully initialize uprobe_trace_consumer before uprobe_register()

2013-01-28 Thread Srikar Dronamraju
* Oleg Nesterov o...@redhat.com [2013-01-27 20:48:37]: probe_event_enable() does uprobe_register() and only after that sets utc-tu and tu-consumer/flags. This can race with uprobe_dispatcher() which can miss these assignments or see them out of order. Nothing really bad can happen, but this

[PATCH 2/4] uprobes: Fully initialize uprobe_trace_consumer before uprobe_register()

2013-01-27 Thread Oleg Nesterov
probe_event_enable() does uprobe_register() and only after that sets utc->tu and tu->consumer/flags. This can race with uprobe_dispatcher() which can miss these assignments or see them out of order. Nothing really bad can happen, but this doesn't look clean/safe. And this does not allow to use

[PATCH 2/4] uprobes: Fully initialize uprobe_trace_consumer before uprobe_register()

2013-01-27 Thread Oleg Nesterov
probe_event_enable() does uprobe_register() and only after that sets utc-tu and tu-consumer/flags. This can race with uprobe_dispatcher() which can miss these assignments or see them out of order. Nothing really bad can happen, but this doesn't look clean/safe. And this does not allow to use