Re: [PATCH 2/4] uprobes: fix register_for_each_vma()->vma_address() check

2012-07-25 Thread Srikar Dronamraju
* Oleg Nesterov [2012-07-12 19:10:20]: > 1. register_for_each_vma() checks that vma_address() == vaddr but >this is not enough. We should also ensure that vaddr >= vm_start, >find_vma() guarantees "vaddr < vm_end" only. > > 2. After the prevous changes, register_for_each_vma() is the onl

[PATCH 2/4] uprobes: fix register_for_each_vma()->vma_address() check

2012-07-12 Thread Oleg Nesterov
1. register_for_each_vma() checks that vma_address() == vaddr but this is not enough. We should also ensure that vaddr >= vm_start, find_vma() guarantees "vaddr < vm_end" only. 2. After the prevous changes, register_for_each_vma() is the only reason why vma_address() has to return loff_t,