Re: [PATCH 2/4] vfio: ccw: refactor and improve pfn_array_alloc_pin()

2018-03-28 Thread Cornelia Huck
On Wed, 28 Mar 2018 10:36:38 +0800 Dong Jia Shi wrote: > * Cornelia Huck [2018-03-27 12:01:27 +0200]: > > [...] > > > > > > > > > So, basically everything is filled by pfn_array_alloc_pin()? > > > Yes. > > > > > > > Should we expect a

Re: [PATCH 2/4] vfio: ccw: refactor and improve pfn_array_alloc_pin()

2018-03-28 Thread Cornelia Huck
On Wed, 28 Mar 2018 10:36:38 +0800 Dong Jia Shi wrote: > * Cornelia Huck [2018-03-27 12:01:27 +0200]: > > [...] > > > > > > > > > So, basically everything is filled by pfn_array_alloc_pin()? > > > Yes. > > > > > > > Should we expect a clean struct pfn_array handed in by the caller, >

Re: [PATCH 2/4] vfio: ccw: refactor and improve pfn_array_alloc_pin()

2018-03-27 Thread Cornelia Huck
On Tue, 27 Mar 2018 11:00:26 +0800 Dong Jia Shi wrote: > * Cornelia Huck [2018-03-26 15:28:46 +0200]: > > > On Wed, 21 Mar 2018 03:08:20 +0100 > > Dong Jia Shi wrote: > > > > > This refactors pfn_array_alloc_pin()

Re: [PATCH 2/4] vfio: ccw: refactor and improve pfn_array_alloc_pin()

2018-03-27 Thread Cornelia Huck
On Tue, 27 Mar 2018 11:00:26 +0800 Dong Jia Shi wrote: > * Cornelia Huck [2018-03-26 15:28:46 +0200]: > > > On Wed, 21 Mar 2018 03:08:20 +0100 > > Dong Jia Shi wrote: > > > > > This refactors pfn_array_alloc_pin() and also improves it by adding > > > defensive code in error handling so

Re: [PATCH 2/4] vfio: ccw: refactor and improve pfn_array_alloc_pin()

2018-03-26 Thread Cornelia Huck
On Wed, 21 Mar 2018 03:08:20 +0100 Dong Jia Shi wrote: > This refactors pfn_array_alloc_pin() and also improves it by adding > defensive code in error handling so that calling pfn_array_unpin_free() > after error return won't lead to problem. This mains does: > 1.

Re: [PATCH 2/4] vfio: ccw: refactor and improve pfn_array_alloc_pin()

2018-03-26 Thread Cornelia Huck
On Wed, 21 Mar 2018 03:08:20 +0100 Dong Jia Shi wrote: > This refactors pfn_array_alloc_pin() and also improves it by adding > defensive code in error handling so that calling pfn_array_unpin_free() > after error return won't lead to problem. This mains does: > 1. Merge pfn_array_pin() into

[PATCH 2/4] vfio: ccw: refactor and improve pfn_array_alloc_pin()

2018-03-20 Thread Dong Jia Shi
This refactors pfn_array_alloc_pin() and also improves it by adding defensive code in error handling so that calling pfn_array_unpin_free() after error return won't lead to problem. This mains does: 1. Merge pfn_array_pin() into pfn_array_alloc_pin(), since there is no other user of

[PATCH 2/4] vfio: ccw: refactor and improve pfn_array_alloc_pin()

2018-03-20 Thread Dong Jia Shi
This refactors pfn_array_alloc_pin() and also improves it by adding defensive code in error handling so that calling pfn_array_unpin_free() after error return won't lead to problem. This mains does: 1. Merge pfn_array_pin() into pfn_array_alloc_pin(), since there is no other user of