Re: [PATCH 2/4] watchdog: iTCO_wdt: Use device managed resources

2017-01-03 Thread Guenter Roeck
On 01/03/2017 02:41 PM, Andy Shevchenko wrote: On Tue, Jan 3, 2017 at 4:39 PM, Guenter Roeck wrote: Using device managed resources simplifies error handling and cleanup, and to reduce the likelyhood of errors. Signed-off-by: Guenter Roeck Reviewed-by: Andy Shevchenko Does it make sense to

Re: [PATCH 2/4] watchdog: iTCO_wdt: Use device managed resources

2017-01-03 Thread Guenter Roeck
On Wed, Jan 04, 2017 at 12:41:56AM +0200, Andy Shevchenko wrote: > On Tue, Jan 3, 2017 at 4:39 PM, Guenter Roeck wrote: > > Using device managed resources simplifies error handling and cleanup, > > and to reduce the likelyhood of errors. > > > > Signed-off-by: Guenter Roeck > > Reviewed-by: Andy

Re: [PATCH 2/4] watchdog: iTCO_wdt: Use device managed resources

2017-01-03 Thread Andy Shevchenko
On Tue, Jan 3, 2017 at 4:39 PM, Guenter Roeck wrote: > Using device managed resources simplifies error handling and cleanup, > and to reduce the likelyhood of errors. > > Signed-off-by: Guenter Roeck Reviewed-by: Andy Shevchenko Does it make sense to convert to dev_err() at some point? > ---

[PATCH 2/4] watchdog: iTCO_wdt: Use device managed resources

2017-01-03 Thread Guenter Roeck
Using device managed resources simplifies error handling and cleanup, and to reduce the likelyhood of errors. Signed-off-by: Guenter Roeck --- drivers/watchdog/iTCO_wdt.c | 80 ++--- 1 file changed, 17 insertions(+), 63 deletions(-) diff --git a/drivers/w