Re: [PATCH 2/4] x86: ia32entry.S: fix wrong symbolic constant usage: R11->ARGOFFSET

2015-01-13 Thread Andy Lutomirski
On Sat, Jan 10, 2015 at 2:00 PM, Denys Vlasenko wrote: > The values of these two constants are the same, the meaning is different. > > Signed-off-by: Denys Vlasenko > Acked-by: Borislav Petkov > CC: Linus Torvalds > CC: Oleg Nesterov > CC: "H. Peter Anvin" > CC: Borislav Petkov > CC: Andy Lu

Re: [PATCH 2/4] x86: ia32entry.S: fix wrong symbolic constant usage: R11->ARGOFFSET

2015-01-10 Thread Andy Lutomirski
On Sat, Jan 10, 2015 at 2:27 PM, Linus Torvalds wrote: > On Sat, Jan 10, 2015 at 2:13 PM, Andy Lutomirski wrote: >> >> I'll make the same change to my pending entry work, and hopefully we >> can avoid conflicts. > > That's not how conflicts work. > > Either there is no overlap between the changes

Re: [PATCH 2/4] x86: ia32entry.S: fix wrong symbolic constant usage: R11->ARGOFFSET

2015-01-10 Thread Borislav Petkov
On Sat, Jan 10, 2015 at 02:41:07PM -0800, Linus Torvalds wrote: > On Sat, Jan 10, 2015 at 2:35 PM, Borislav Petkov wrote: > > > > Haha, Linus just made you maintainer of entry_64.S :-) > > Just going by > > git shortlog --no-merges --since=6.months arch/x86/kernel/entry_64.S > > and looking

Re: [PATCH 2/4] x86: ia32entry.S: fix wrong symbolic constant usage: R11->ARGOFFSET

2015-01-10 Thread Linus Torvalds
On Sat, Jan 10, 2015 at 2:35 PM, Borislav Petkov wrote: > > Haha, Linus just made you maintainer of entry_64.S :-) Just going by git shortlog --no-merges --since=6.months arch/x86/kernel/entry_64.S and looking at the kind of changes are going on, I really think a "tag, you're it" to Andy is

Re: [PATCH 2/4] x86: ia32entry.S: fix wrong symbolic constant usage: R11->ARGOFFSET

2015-01-10 Thread Linus Torvalds
On Sat, Jan 10, 2015 at 2:27 PM, Linus Torvalds wrote: > > So the only way to avoid a conflict is to not touch the same code, or > to touch it *exactly* the same way in all respects. .. with the caveat that the exact definition of "overlap" can end up being somewhat fuzzy with the whole conflict

Re: [PATCH 2/4] x86: ia32entry.S: fix wrong symbolic constant usage: R11->ARGOFFSET

2015-01-10 Thread Borislav Petkov
On Sat, Jan 10, 2015 at 02:27:06PM -0800, Linus Torvalds wrote: > I I do actually agree with you taking the fixes (and maybe you should > *entirely* take ownership of all the entry_64.S changes, so that there > is no "other side" to conflict with at all!). I just wanted to point > out the actual ef

Re: [PATCH 2/4] x86: ia32entry.S: fix wrong symbolic constant usage: R11->ARGOFFSET

2015-01-10 Thread Linus Torvalds
On Sat, Jan 10, 2015 at 2:13 PM, Andy Lutomirski wrote: > > I'll make the same change to my pending entry work, and hopefully we > can avoid conflicts. That's not how conflicts work. Either there is no overlap between the changes at all, in which case it doesn't matter if you then also have Deny

Re: [PATCH 2/4] x86: ia32entry.S: fix wrong symbolic constant usage: R11->ARGOFFSET

2015-01-10 Thread Andy Lutomirski
On Sat, Jan 10, 2015 at 2:00 PM, Denys Vlasenko wrote: > The values of these two constants are the same, the meaning is different. Acked-by: Andy Lutomirski I'll make the same change to my pending entry work, and hopefully we can avoid conflicts. --Andy > > Signed-off-by: Denys Vlasenko > Ac

[PATCH 2/4] x86: ia32entry.S: fix wrong symbolic constant usage: R11->ARGOFFSET

2015-01-10 Thread Denys Vlasenko
The values of these two constants are the same, the meaning is different. Signed-off-by: Denys Vlasenko Acked-by: Borislav Petkov CC: Linus Torvalds CC: Oleg Nesterov CC: "H. Peter Anvin" CC: Borislav Petkov CC: Andy Lutomirski CC: Frederic Weisbecker CC: X86 ML CC: Alexei Starovoitov CC

Re: [PATCH 2/4] x86: ia32entry.S: fix wrong symbolic constant usage: R11->ARGOFFSET

2015-01-09 Thread Borislav Petkov
On Thu, Jan 08, 2015 at 05:25:13PM +0100, Denys Vlasenko wrote: > The values of these two constants are the same, the meaning is different. > > Signed-off-by: Denys Vlasenko > CC: Linus Torvalds > CC: Oleg Nesterov > CC: "H. Peter Anvin" > CC: Andy Lutomirski > CC: Frederic Weisbecker > CC:

[PATCH 2/4] x86: ia32entry.S: fix wrong symbolic constant usage: R11->ARGOFFSET

2015-01-08 Thread Denys Vlasenko
The values of these two constants are the same, the meaning is different. Signed-off-by: Denys Vlasenko CC: Linus Torvalds CC: Oleg Nesterov CC: "H. Peter Anvin" CC: Andy Lutomirski CC: Frederic Weisbecker CC: X86 ML CC: Alexei Starovoitov CC: Will Drewry CC: Kees Cook CC: linux-kernel@v