Re: [PATCH 2/5] Add aix lvm partitions support files

2013-08-12 Thread Alasdair G Kergon
On Mon, Aug 12, 2013 at 04:52:34AM -0700, Christoph Hellwig wrote: > lvm is mostly about the Linux specific formats. If you want to create > a separate userspace consumer for device mapper that's probably also > fine, but if you need support for complex layours device mapper is the > way to go, an

Re: [PATCH 2/5] Add aix lvm partitions support files

2013-08-12 Thread Christoph Hellwig
On Fri, May 24, 2013 at 12:58:52PM +0200, Philippe De Muyter wrote: > > This very much screams like it should be implemented in the lvm2 > > userspace package using the dm kernel driver. > > Is lvm2 a generic tool for discovering foreign partition layouts, or it is > about one linux-specific lvm i

Re: [PATCH 2/5] Add aix lvm partitions support files

2013-05-24 Thread Philippe De Muyter
On Fri, May 24, 2013 at 06:04:52AM -0400, Christoph Hellwig wrote: > On Tue, May 21, 2013 at 09:27:54AM +0200, Philippe De Muyter wrote: > > AIX LVM permits to make "logical volumes" which are made of multiple slices > > of multiple disks. The new code allows only access to the "logical volumes" >

Re: [PATCH 2/5] Add aix lvm partitions support files

2013-05-24 Thread Christoph Hellwig
On Tue, May 21, 2013 at 09:27:54AM +0200, Philippe De Muyter wrote: > AIX LVM permits to make "logical volumes" which are made of multiple slices > of multiple disks. The new code allows only access to the "logical volumes" > which are made of one slice on the probed disk, a slice being a contiguo

Re: [PATCH 2/5] Add aix lvm partitions support files

2013-05-21 Thread Philippe De Muyter
Hi Andrew, On Mon, May 20, 2013 at 04:39:27PM -0700, Andrew Morton wrote: > On Mon, 29 Apr 2013 23:18:30 +0200 Philippe De Muyter wrote: > > > adding partitions/aix.h and partitions/aix.c > > > > Partitions (called Logical Volumes in AIX) can be non-contiguous or > > even split on more than one

Re: [PATCH 2/5] Add aix lvm partitions support files

2013-05-20 Thread Andrew Morton
On Mon, 29 Apr 2013 23:18:30 +0200 Philippe De Muyter wrote: > adding partitions/aix.h and partitions/aix.c > > Partitions (called Logical Volumes in AIX) can be non-contiguous or > even split on more than one disk. Altough we detect such partitions, > we cannot describe them to the Linux parti

Re: [PATCH 2/5] Add aix lvm partitions support files

2013-04-30 Thread Philippe De Muyter
On Tue, Apr 30, 2013 at 09:18:40AM +0200, Philippe De Muyter wrote: > On Tue, Apr 30, 2013 at 09:08:40AM +0200, Philippe De Muyter wrote: > > On Mon, Apr 29, 2013 at 11:50:51PM +0200, Philippe De Muyter wrote: > > > On Mon, Apr 29, 2013 at 01:40:41PM +0200, Philippe De Muyter wrote: > > > > On Mon,

Re: [PATCH 2/5] Add aix lvm partitions support files

2013-04-30 Thread Philippe De Muyter
On Tue, Apr 30, 2013 at 09:08:40AM +0200, Philippe De Muyter wrote: > On Mon, Apr 29, 2013 at 11:50:51PM +0200, Philippe De Muyter wrote: > > On Mon, Apr 29, 2013 at 01:40:41PM +0200, Philippe De Muyter wrote: > > > On Mon, Apr 29, 2013 at 11:37:56AM +0200, Karel Zak wrote: > > > > > > > > Philipp

Re: [PATCH 2/5] Add aix lvm partitions support files

2013-04-30 Thread Philippe De Muyter
On Mon, Apr 29, 2013 at 11:50:51PM +0200, Philippe De Muyter wrote: > On Mon, Apr 29, 2013 at 01:40:41PM +0200, Philippe De Muyter wrote: > > On Mon, Apr 29, 2013 at 11:37:56AM +0200, Karel Zak wrote: > > > > > > Philippe, do you have any disk image with AIX LVM? It would be nice to > > > have a w

Re: [PATCH 2/5] Add aix lvm partitions support files

2013-04-29 Thread Philippe De Muyter
On Tue, Apr 30, 2013 at 08:41:52AM +0200, Jens Axboe wrote: > On Mon, Apr 29 2013, Philippe De Muyter wrote: > > > > so sda is 8,0 and sdb is 8,16 > > > > and if, while discovering partitions of /dev/sda, I try to make a > > partition 16 or higher, it is silently discarded by 'put_partition'. > >

Re: [PATCH 2/5] Add aix lvm partitions support files

2013-04-29 Thread Jens Axboe
On Mon, Apr 29 2013, Philippe De Muyter wrote: > Hi Karel > > On Mon, Apr 29, 2013 at 02:36:51PM +0200, Karel Zak wrote: > > On Mon, Apr 29, 2013 at 01:40:41PM +0200, Philippe De Muyter wrote: > > > > why not memset(pps_found, )? I also see magical constant 16 > > > > > > Actually 16 is the m

Re: [PATCH 2/5] Add aix lvm partitions support files

2013-04-29 Thread Philippe De Muyter
On Mon, Apr 29, 2013 at 01:40:41PM +0200, Philippe De Muyter wrote: > On Mon, Apr 29, 2013 at 11:37:56AM +0200, Karel Zak wrote: > > > > Philippe, do you have any disk image with AIX LVM? It would be nice to > > have a way how to test the code. I'd like to add support for AIX to > > libblkid too.

[PATCH 2/5] Add aix lvm partitions support files

2013-04-29 Thread Philippe De Muyter
adding partitions/aix.h and partitions/aix.c Partitions (called Logical Volumes in AIX) can be non-contiguous or even split on more than one disk. Altough we detect such partitions, we cannot describe them to the Linux partitions layer, so we simply discard them and issue a diagnose message. Sig

Re: [PATCH 2/5] Add aix lvm partitions support files

2013-04-29 Thread Philippe De Muyter
Hi Karel On Mon, Apr 29, 2013 at 02:36:51PM +0200, Karel Zak wrote: > On Mon, Apr 29, 2013 at 01:40:41PM +0200, Philippe De Muyter wrote: > > > why not memset(pps_found, )? I also see magical constant 16 > > > > Actually 16 is the maximum partition count allowed in a disk by linux, > > or sho

Re: [PATCH 2/5] Add aix lvm partitions support files

2013-04-29 Thread Karel Zak
On Mon, Apr 29, 2013 at 01:40:41PM +0200, Philippe De Muyter wrote: > > why not memset(pps_found, )? I also see magical constant 16 > > Actually 16 is the maximum partition count allowed in a disk by linux, > or should it be 15 ? Is there already a constant for that ? > The AIX disk I tested

Re: [PATCH 2/5] Add aix lvm partitions support files

2013-04-29 Thread Philippe De Muyter
On Mon, Apr 29, 2013 at 11:37:56AM +0200, Karel Zak wrote: > On Thu, Apr 25, 2013 at 11:10:26PM +0200, Philippe De Muyter wrote: Thanks for the interest and the quick reply. > > +int aix_partition(struct parsed_partitions *state) > > +{ > > + int ret = 0; > > + Sector sect; > > + unsigned c

Re: [PATCH 2/5] Add aix lvm partitions support files

2013-04-29 Thread Karel Zak
On Thu, Apr 25, 2013 at 11:10:26PM +0200, Philippe De Muyter wrote: > +int aix_partition(struct parsed_partitions *state) > +{ > + int ret = 0; > + Sector sect; > + unsigned char *d; > + u32 pp_bytes_size; > + u32 pp_blocks_size = 0; > + u32 vgda_sector = 0; > + u32 vgda

[PATCH 2/5] Add aix lvm partitions support files

2013-04-25 Thread Philippe De Muyter
adding partitions/aix.h and partitions/aix.c Partitions (called Logical Volumes in AIX) can be non-contiguous or even split on more than one disk. Altough we detect such partitions, we cannot describe them to the Linux partitions layer, so we simply discard them and issue a diagnose message. Sig