Re: [PATCH 2/5] arm64: perf: Implement correct cap_user_time

2020-05-12 Thread kbuild test robot
Hi Peter, I love your patch! Yet something to improve: [auto build test ERROR on tip/perf/core] [also build test ERROR on arm64/for-next/core arm-perf/for-next/perf linus/master v5.7-rc5 next-20200512] [if your patch is applied to the wrong git tree, please drop us a note to help improve the

Re: [PATCH 2/5] arm64: perf: Implement correct cap_user_time

2020-05-12 Thread Peter Zijlstra
On Tue, May 12, 2020 at 10:03:01PM +0800, Leo Yan wrote: > > + if (userpg->shift == 32) { > > Thanks a lot for the patch set, some typos: > > s/shift/time_shift > > > + userpg->shift = 31; > > s/shift/time_shift Blergh.. so much for me not taking the time to dig out the arm64

Re: [PATCH 2/5] arm64: perf: Implement correct cap_user_time

2020-05-12 Thread Leo Yan
Hi Peter, On Tue, May 12, 2020 at 02:41:00PM +0200, Peter Zijlstra wrote: > As reported by Leo; the existing implementation is broken when the > clock and counter don't intersect at 0. > > Use the sched_clock's struct clock_read_data information to correctly > implement cap_user_time and

[PATCH 2/5] arm64: perf: Implement correct cap_user_time

2020-05-12 Thread Peter Zijlstra
As reported by Leo; the existing implementation is broken when the clock and counter don't intersect at 0. Use the sched_clock's struct clock_read_data information to correctly implement cap_user_time and cap_user_time_zero. Note that the ARM64 counter is architecturally only guaranteed to be