Re: [PATCH 2/5] block: add function to issue compare and write

2014-10-18 Thread Christoph Hellwig
On Fri, Oct 17, 2014 at 07:38:37PM -0400, Martin K. Petersen wrote: > The problem with this is that, as it stands, a bio has no type. And it > would suck if we couldn't keep bio rw and request flags in sync. > > I wonder if it would make more sense to move the remaining rq types to > cmd_flags aft

Re: [PATCH 2/5] block: add function to issue compare and write

2014-10-17 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> We already have req->cmd_type which actually is a fairly good Christoph> description of what we get except for REQ_TYPE_FS, which is a Christoph> horrible overload using req->cmd_flags. Christoph> Given that you're just one of many curren

Re: [PATCH 2/5] block: add function to issue compare and write

2014-10-17 Thread Christoph Hellwig
On Thu, Oct 16, 2014 at 12:37:12AM -0500, micha...@cs.wisc.edu wrote: > @@ -160,7 +160,7 @@ enum rq_flag_bits { > __REQ_DISCARD, /* request to discard sectors */ > __REQ_SECURE, /* secure discard (used with __REQ_DISCARD) */ > __REQ_WRITE_SAME, /* write sa