Re: [PATCH 2/5] eCryptfs: convert kmap() to kmap_atomic()

2007-01-19 Thread Pekka Enberg
On 1/18/07, Michael Halcrow <[EMAIL PROTECTED]> wrote: + page_data = (char *)kmap_atomic(page, KM_USER0); + lower_page_data = (char *)kmap_atomic(lower_page, KM_USER1); Drop 'em redundant casts, please. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH 2/5] eCryptfs: convert kmap() to kmap_atomic()

2007-01-19 Thread Pekka Enberg
On 1/18/07, Michael Halcrow [EMAIL PROTECTED] wrote: + page_data = (char *)kmap_atomic(page, KM_USER0); + lower_page_data = (char *)kmap_atomic(lower_page, KM_USER1); Drop 'em redundant casts, please. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the

[PATCH 2/5] eCryptfs: convert kmap() to kmap_atomic()

2007-01-18 Thread Michael Halcrow
On Tue, Jan 09, 2007 at 02:42:03PM -0800, Andrew Morton wrote: > On Tue, 9 Jan 2007 16:23:37 -0600 > Michael Halcrow <[EMAIL PROTECTED]> wrote: > > > + page_virt = (char *)kmap(page); > > Do we _have_ to use kmap here? It's slow and theoretically > deadlocky.

[PATCH 2/5] eCryptfs: convert kmap() to kmap_atomic()

2007-01-18 Thread Michael Halcrow
On Tue, Jan 09, 2007 at 02:42:03PM -0800, Andrew Morton wrote: On Tue, 9 Jan 2007 16:23:37 -0600 Michael Halcrow [EMAIL PROTECTED] wrote: + page_virt = (char *)kmap(page); Do we _have_ to use kmap here? It's slow and theoretically deadlocky. kmap_atomic() is