Re: [PATCH 2/5] extcon: gpio: Convert the driver to use gpio desc API's

2014-09-22 Thread George Cherian
On 09/23/2014 04:44 AM, Chanwoo Choi wrote: On 09/22/2014 06:51 PM, George Cherian wrote: On 09/22/2014 01:37 PM, Chanwoo Choi wrote: Hi George, This patch removes 'gpio_active_low' field of struct gpio_extcon_data. But, include/linux/extcon-gpio.h has the description of 'gpio_active_low'

Re: [PATCH 2/5] extcon: gpio: Convert the driver to use gpio desc API's

2014-09-22 Thread Chanwoo Choi
On 09/22/2014 06:51 PM, George Cherian wrote: > > On 09/22/2014 01:37 PM, Chanwoo Choi wrote: >> Hi George, >> >> This patch removes 'gpio_active_low' field of struct gpio_extcon_data. >> But, include/linux/extcon-gpio.h has the description of 'gpio_active_low' >> field. > Yes didn't want the

Re: [PATCH 2/5] extcon: gpio: Convert the driver to use gpio desc API's

2014-09-22 Thread George Cherian
On 09/22/2014 01:37 PM, Chanwoo Choi wrote: Hi George, This patch removes 'gpio_active_low' field of struct gpio_extcon_data. But, include/linux/extcon-gpio.h has the description of 'gpio_active_low' field. Yes didn't want the platform data users to break. Actually I couldn't find any

Re: [PATCH 2/5] extcon: gpio: Convert the driver to use gpio desc API's

2014-09-22 Thread Chanwoo Choi
Hi George, This patch removes 'gpio_active_low' field of struct gpio_extcon_data. But, include/linux/extcon-gpio.h has the description of 'gpio_active_low' field. Also, This patch has not included the any description/comment of removing 'gpio_active_low'. Also, How to set 'FLAG_ACTIVE_LOW' bit

Re: [PATCH 2/5] extcon: gpio: Convert the driver to use gpio desc API's

2014-09-22 Thread Chanwoo Choi
Hi George, This patch removes 'gpio_active_low' field of struct gpio_extcon_data. But, include/linux/extcon-gpio.h has the description of 'gpio_active_low' field. Also, This patch has not included the any description/comment of removing 'gpio_active_low'. Also, How to set 'FLAG_ACTIVE_LOW' bit

Re: [PATCH 2/5] extcon: gpio: Convert the driver to use gpio desc API's

2014-09-22 Thread George Cherian
On 09/22/2014 01:37 PM, Chanwoo Choi wrote: Hi George, This patch removes 'gpio_active_low' field of struct gpio_extcon_data. But, include/linux/extcon-gpio.h has the description of 'gpio_active_low' field. Yes didn't want the platform data users to break. Actually I couldn't find any

Re: [PATCH 2/5] extcon: gpio: Convert the driver to use gpio desc API's

2014-09-22 Thread Chanwoo Choi
On 09/22/2014 06:51 PM, George Cherian wrote: On 09/22/2014 01:37 PM, Chanwoo Choi wrote: Hi George, This patch removes 'gpio_active_low' field of struct gpio_extcon_data. But, include/linux/extcon-gpio.h has the description of 'gpio_active_low' field. Yes didn't want the platform data

Re: [PATCH 2/5] extcon: gpio: Convert the driver to use gpio desc API's

2014-09-22 Thread George Cherian
On 09/23/2014 04:44 AM, Chanwoo Choi wrote: On 09/22/2014 06:51 PM, George Cherian wrote: On 09/22/2014 01:37 PM, Chanwoo Choi wrote: Hi George, This patch removes 'gpio_active_low' field of struct gpio_extcon_data. But, include/linux/extcon-gpio.h has the description of 'gpio_active_low'

[PATCH 2/5] extcon: gpio: Convert the driver to use gpio desc API's

2014-09-08 Thread George Cherian
Convert the driver to use gpiod_* API's. Signed-off-by: George Cherian --- drivers/extcon/extcon-gpio.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c index 72f19a3..25269f6 100644 ---

[PATCH 2/5] extcon: gpio: Convert the driver to use gpio desc API's

2014-09-08 Thread George Cherian
Convert the driver to use gpiod_* API's. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/extcon/extcon-gpio.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c index 72f19a3..25269f6