Re: [PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-04 Thread David Woodhouse
On Fri, 2007-05-04 at 14:41 +0200, Haavard Skinnemoen wrote: > > Hmm...everything else in lib/Kconfig is supposed to be _selected_, not > depended upon. And the only three items in there which can actually be > selected by the user all begin their helptexts with > > "This option is provided for

Re: [PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-04 Thread Haavard Skinnemoen
On Fri, 04 May 2007 12:35:32 +0100 David Woodhouse <[EMAIL PROTECTED]> wrote: > On Fri, 2007-05-04 at 12:30 +0100, Richard Purdie wrote: > > +config JFFS2_LZO > > + bool "JFFS2 LZO compression support" if JFFS2_COMPRESSION_OPTIONS > > + select LZO > > Please make it _depend_ on

[PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-04 Thread Richard Purdie
Add LZO1X compression/decompression support to jffs2. LZO's interface doesn't entirely match that required by jffs2 so a buffer and memcpy is unavoidable. Signed-off-by: Richard Purdie <[EMAIL PROTECTED]> --- fs/Kconfig| 10 fs/jffs2/Makefile |1 + fs/jffs2/compr.c

Re: [PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-04 Thread David Woodhouse
On Fri, 2007-05-04 at 12:30 +0100, Richard Purdie wrote: > +config JFFS2_LZO > + bool "JFFS2 LZO compression support" if JFFS2_COMPRESSION_OPTIONS > + select LZO Please make it _depend_ on LZO instead. If you do that, I can merge the JFFS2 bits in anticipation of the core LZO code

[PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-04 Thread Richard Purdie
Add LZO1X compression/decompression support to jffs2. LZO's interface doesn't entirely match that required by jffs2 so a buffer and memcpy is unavoidable. Signed-off-by: Richard Purdie <[EMAIL PROTECTED]> --- fs/Kconfig| 11 + fs/jffs2/Makefile |1 + fs/jffs2/compr.c

Re: [PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-04 Thread Richard Purdie
On Fri, 2007-05-04 at 14:36 +0530, Satyam Sharma wrote: > On 5/1/07, Richard Purdie <[EMAIL PROTECTED]> wrote: > > +++ b/fs/jffs2/compr_lzo.c > > [...] > > +static void *lzo_mem; > > +static void *lzo_compress_buf; > > +static DEFINE_MUTEX(deflate_mutex); > > + > > +static void

Re: [PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-04 Thread Satyam Sharma
Hi Richard, On 5/1/07, Richard Purdie <[EMAIL PROTECTED]> wrote: Add LZO1X compression/decompression support to jffs2. LZO's interface doesn't entirely match that required by jffs2 so a buffer and memcpy is unavoidable. Signed-off-by: Richard Purdie <[EMAIL PROTECTED]> --- [...] +++

Re: [PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-04 Thread Satyam Sharma
Hi Richard, On 5/1/07, Richard Purdie [EMAIL PROTECTED] wrote: Add LZO1X compression/decompression support to jffs2. LZO's interface doesn't entirely match that required by jffs2 so a buffer and memcpy is unavoidable. Signed-off-by: Richard Purdie [EMAIL PROTECTED] --- [...] +++

Re: [PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-04 Thread Richard Purdie
On Fri, 2007-05-04 at 14:36 +0530, Satyam Sharma wrote: On 5/1/07, Richard Purdie [EMAIL PROTECTED] wrote: +++ b/fs/jffs2/compr_lzo.c [...] +static void *lzo_mem; +static void *lzo_compress_buf; +static DEFINE_MUTEX(deflate_mutex); + +static void free_workspace(void) +{ +

[PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-04 Thread Richard Purdie
Add LZO1X compression/decompression support to jffs2. LZO's interface doesn't entirely match that required by jffs2 so a buffer and memcpy is unavoidable. Signed-off-by: Richard Purdie [EMAIL PROTECTED] --- fs/Kconfig| 11 + fs/jffs2/Makefile |1 + fs/jffs2/compr.c

Re: [PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-04 Thread David Woodhouse
On Fri, 2007-05-04 at 12:30 +0100, Richard Purdie wrote: +config JFFS2_LZO + bool JFFS2 LZO compression support if JFFS2_COMPRESSION_OPTIONS + select LZO Please make it _depend_ on LZO instead. If you do that, I can merge the JFFS2 bits in anticipation of the core LZO code going

[PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-04 Thread Richard Purdie
Add LZO1X compression/decompression support to jffs2. LZO's interface doesn't entirely match that required by jffs2 so a buffer and memcpy is unavoidable. Signed-off-by: Richard Purdie [EMAIL PROTECTED] --- fs/Kconfig| 10 fs/jffs2/Makefile |1 + fs/jffs2/compr.c

Re: [PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-04 Thread Haavard Skinnemoen
On Fri, 04 May 2007 12:35:32 +0100 David Woodhouse [EMAIL PROTECTED] wrote: On Fri, 2007-05-04 at 12:30 +0100, Richard Purdie wrote: +config JFFS2_LZO + bool JFFS2 LZO compression support if JFFS2_COMPRESSION_OPTIONS + select LZO Please make it _depend_ on LZO instead. If

Re: [PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-04 Thread David Woodhouse
On Fri, 2007-05-04 at 14:41 +0200, Haavard Skinnemoen wrote: Hmm...everything else in lib/Kconfig is supposed to be _selected_, not depended upon. And the only three items in there which can actually be selected by the user all begin their helptexts with This option is provided for the

Re: [PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-01 Thread Randy Dunlap
On Tue, 01 May 2007 15:47:03 +0100 Richard Purdie wrote: > Add LZO1X compression/decompression support to jffs2. > > LZO's interface doesn't entirely match that required by jffs2 so a > buffer and memcpy is unavoidable. > > Signed-off-by: Richard Purdie <[EMAIL PROTECTED]> > --- > > diff --git

[PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-01 Thread Richard Purdie
Add LZO1X compression/decompression support to jffs2. LZO's interface doesn't entirely match that required by jffs2 so a buffer and memcpy is unavoidable. Signed-off-by: Richard Purdie <[EMAIL PROTECTED]> --- fs/Kconfig| 10 fs/jffs2/Makefile |1 + fs/jffs2/compr.c

[PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-01 Thread Richard Purdie
Add LZO1X compression/decompression support to jffs2. LZO's interface doesn't entirely match that required by jffs2 so a buffer and memcpy is unavoidable. Signed-off-by: Richard Purdie [EMAIL PROTECTED] --- fs/Kconfig| 10 fs/jffs2/Makefile |1 + fs/jffs2/compr.c

Re: [PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-01 Thread Randy Dunlap
On Tue, 01 May 2007 15:47:03 +0100 Richard Purdie wrote: Add LZO1X compression/decompression support to jffs2. LZO's interface doesn't entirely match that required by jffs2 so a buffer and memcpy is unavoidable. Signed-off-by: Richard Purdie [EMAIL PROTECTED] --- diff --git

Re: [PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-04-25 Thread David Woodhouse
On Wed, 2007-02-28 at 19:13 +, Richard Purdie wrote: > Add LZO1X compression/decompression support to jffs2. > > LZO's interface doesn't entirely match that required by jffs2 so a > buffer and memcpy is unavoidable. > > Signed-off-by: Richard Purdie <[EMAIL PROTECTED]> > Index:

Re: [PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-04-25 Thread David Woodhouse
On Wed, 2007-02-28 at 19:13 +, Richard Purdie wrote: Add LZO1X compression/decompression support to jffs2. LZO's interface doesn't entirely match that required by jffs2 so a buffer and memcpy is unavoidable. Signed-off-by: Richard Purdie [EMAIL PROTECTED] Index:

[PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-02-28 Thread Richard Purdie
Add LZO1X compression/decompression support to jffs2. LZO's interface doesn't entirely match that required by jffs2 so a buffer and memcpy is unavoidable. Signed-off-by: Richard Purdie <[EMAIL PROTECTED]> --- fs/Kconfig| 10 fs/jffs2/Makefile |1 fs/jffs2/compr.c

[PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-02-28 Thread Richard Purdie
Add LZO1X compression/decompression support to jffs2. LZO's interface doesn't entirely match that required by jffs2 so a buffer and memcpy is unavoidable. Signed-off-by: Richard Purdie [EMAIL PROTECTED] --- fs/Kconfig| 10 fs/jffs2/Makefile |1 fs/jffs2/compr.c