Re: [PATCH 2/5] lguest guest feedback tidyups

On Sun, 2007-05-13 at 19:43 +0100, Al Viro wrote: > On Fri, May 11, 2007 at 11:21:30AM +1000, Rusty Russell wrote: > > /* Devices are in page above top of "normal" mem. */ > > - lguest_devices = ioremap(max_pfn << PAGE_SHIFT, PAGE_SIZE); > > + lguest_devices = (__force

Re: [PATCH 2/5] lguest guest feedback tidyups

On Sun, 2007-05-13 at 19:43 +0100, Al Viro wrote: On Fri, May 11, 2007 at 11:21:30AM +1000, Rusty Russell wrote: /* Devices are in page above top of normal mem. */ - lguest_devices = ioremap(max_pfn PAGE_SHIFT, PAGE_SIZE); + lguest_devices = (__force

Re: [PATCH 2/5] lguest guest feedback tidyups

On Fri, May 11, 2007 at 11:21:30AM +1000, Rusty Russell wrote: > /* Devices are in page above top of "normal" mem. */ > - lguest_devices = ioremap(max_pfn << PAGE_SHIFT, PAGE_SIZE); > + lguest_devices = (__force void*)ioremap(max_pfn

Re: [PATCH 2/5] lguest guest feedback tidyups

On Fri, May 11, 2007 at 11:21:30AM +1000, Rusty Russell wrote: /* Devices are in page above top of normal mem. */ - lguest_devices = ioremap(max_pfn PAGE_SHIFT, PAGE_SIZE); + lguest_devices = (__force void*)ioremap(max_pfnPAGE_SHIFT,PAGE_SIZE); Er... What's being done here?

Re: [PATCH 2/5] lguest guest feedback tidyups

On Fri, 2007-05-11 at 07:56 +0100, Christoph Hellwig wrote: > On Fri, May 11, 2007 at 11:21:30AM +1000, Rusty Russell wrote: > > 1) send-dma and bind-dma hypercall wrappers for drivers to use, > > 2) formalization of the convention that devices can use the irq > >corresponding to their index

Re: [PATCH 2/5] lguest guest feedback tidyups

On Fri, 2007-05-11 at 08:40 +0100, Christoph Hellwig wrote: > On Fri, May 11, 2007 at 05:31:06PM +1000, Rusty Russell wrote: > > Hi Christoph! > > > I enjoy a good Hellwigging as much as anyone, but your aim is off. > > Please stop this crap. I know who I am, so there's no need to waste > mail

Re: [PATCH 2/5] lguest guest feedback tidyups

On Fri, 2007-05-11 at 08:40 +0100, Christoph Hellwig wrote: On Fri, May 11, 2007 at 05:31:06PM +1000, Rusty Russell wrote: Hi Christoph! I enjoy a good Hellwigging as much as anyone, but your aim is off. Please stop this crap. I know who I am, so there's no need to waste mail estate

Re: [PATCH 2/5] lguest guest feedback tidyups

On Fri, 2007-05-11 at 07:56 +0100, Christoph Hellwig wrote: On Fri, May 11, 2007 at 11:21:30AM +1000, Rusty Russell wrote: 1) send-dma and bind-dma hypercall wrappers for drivers to use, 2) formalization of the convention that devices can use the irq corresponding to their index on the

Re: [PATCH 2/5] lguest guest feedback tidyups

On Fri, May 11, 2007 at 05:31:06PM +1000, Rusty Russell wrote: > Well, without ioremap, the memory wouldn't normally be mapped. Is > there something better to use? Either use accessors or use your own lguest-specific remapping function that doesn't return __iomem function > > So instead

Re: [PATCH 2/5] lguest guest feedback tidyups

On Fri, 2007-05-11 at 07:56 +0100, Christoph Hellwig wrote: > On Fri, May 11, 2007 at 11:21:30AM +1000, Rusty Russell wrote: > > 1) send-dma and bind-dma hypercall wrappers for drivers to use, > > 2) formalization of the convention that devices can use the irq > >corresponding to their index

Re: [PATCH 2/5] lguest guest feedback tidyups

On Fri, May 11, 2007 at 11:21:30AM +1000, Rusty Russell wrote: > 1) send-dma and bind-dma hypercall wrappers for drivers to use, > 2) formalization of the convention that devices can use the irq >corresponding to their index on the lguest_bus. > 3) ___force to shut up sparse: guests *can* use

Re: [PATCH 2/5] lguest guest feedback tidyups

On Fri, May 11, 2007 at 11:21:30AM +1000, Rusty Russell wrote: 1) send-dma and bind-dma hypercall wrappers for drivers to use, 2) formalization of the convention that devices can use the irq corresponding to their index on the lguest_bus. 3) ___force to shut up sparse: guests *can* use

Re: [PATCH 2/5] lguest guest feedback tidyups

On Fri, 2007-05-11 at 07:56 +0100, Christoph Hellwig wrote: On Fri, May 11, 2007 at 11:21:30AM +1000, Rusty Russell wrote: 1) send-dma and bind-dma hypercall wrappers for drivers to use, 2) formalization of the convention that devices can use the irq corresponding to their index on the

Re: [PATCH 2/5] lguest guest feedback tidyups

On Fri, May 11, 2007 at 05:31:06PM +1000, Rusty Russell wrote: Well, without ioremap, the memory wouldn't normally be mapped. Is there something better to use? Either use accessors or use your own lguest-specific remapping function that doesn't return __iomem function So instead of

[PATCH 2/5] lguest guest feedback tidyups

1) send-dma and bind-dma hypercall wrappers for drivers to use, 2) formalization of the convention that devices can use the irq corresponding to their index on the lguest_bus. 3) ___force to shut up sparse: guests *can* use ioremap as virtual mem. 4) lguest.c should include "lguest_bus.h" for

[PATCH 2/5] lguest guest feedback tidyups

1) send-dma and bind-dma hypercall wrappers for drivers to use, 2) formalization of the convention that devices can use the irq corresponding to their index on the lguest_bus. 3) ___force to shut up sparse: guests *can* use ioremap as virtual mem. 4) lguest.c should include lguest_bus.h for