Re: [PATCH 2/5] mm/hmm: Clean up some coding style and comments

2019-06-06 Thread Ralph Campbell
On 6/6/19 8:57 AM, Jason Gunthorpe wrote: On Mon, May 06, 2019 at 04:29:39PM -0700, rcampb...@nvidia.com wrote: @@ -924,6 +922,7 @@ int hmm_range_register(struct hmm_range *range, unsigned page_shift) { unsigned long mask = ((1UL << page_shift) - 1UL); +

Re: [PATCH 2/5] mm/hmm: Clean up some coding style and comments

2019-06-06 Thread Jason Gunthorpe
On Thu, Jun 06, 2019 at 11:52:13AM -0400, Jerome Glisse wrote: > On Thu, Jun 06, 2019 at 12:41:29PM -0300, Jason Gunthorpe wrote: > > On Thu, Jun 06, 2019 at 10:27:43AM -0400, Jerome Glisse wrote: > > > On Thu, Jun 06, 2019 at 11:16:44AM -0300, Jason Gunthorpe wrote: > > > > On Mon, May 06, 2019

Re: [PATCH 2/5] mm/hmm: Clean up some coding style and comments

2019-06-06 Thread Joe Perches
On Thu, 2019-06-06 at 11:52 -0400, Jerome Glisse wrote: > On Thu, Jun 06, 2019 at 12:41:29PM -0300, Jason Gunthorpe wrote: > > On Thu, Jun 06, 2019 at 10:27:43AM -0400, Jerome Glisse wrote: > > > On Thu, Jun 06, 2019 at 11:16:44AM -0300, Jason Gunthorpe wrote: > > > > On Mon, May 06, 2019 at

Re: [PATCH 2/5] mm/hmm: Clean up some coding style and comments

2019-06-06 Thread Jason Gunthorpe
On Mon, May 06, 2019 at 04:29:39PM -0700, rcampb...@nvidia.com wrote: > @@ -924,6 +922,7 @@ int hmm_range_register(struct hmm_range *range, > unsigned page_shift) > { > unsigned long mask = ((1UL << page_shift) - 1UL); > + struct hmm *hmm; > > range->valid =

Re: [PATCH 2/5] mm/hmm: Clean up some coding style and comments

2019-06-06 Thread Jerome Glisse
On Thu, Jun 06, 2019 at 12:41:29PM -0300, Jason Gunthorpe wrote: > On Thu, Jun 06, 2019 at 10:27:43AM -0400, Jerome Glisse wrote: > > On Thu, Jun 06, 2019 at 11:16:44AM -0300, Jason Gunthorpe wrote: > > > On Mon, May 06, 2019 at 04:29:39PM -0700, rcampb...@nvidia.com wrote: > > > > From: Ralph

Re: [PATCH 2/5] mm/hmm: Clean up some coding style and comments

2019-06-06 Thread Jason Gunthorpe
On Thu, Jun 06, 2019 at 10:27:43AM -0400, Jerome Glisse wrote: > On Thu, Jun 06, 2019 at 11:16:44AM -0300, Jason Gunthorpe wrote: > > On Mon, May 06, 2019 at 04:29:39PM -0700, rcampb...@nvidia.com wrote: > > > From: Ralph Campbell > > > > > > There are no functional changes, just some coding

Re: [PATCH 2/5] mm/hmm: Clean up some coding style and comments

2019-06-06 Thread Jerome Glisse
On Thu, Jun 06, 2019 at 11:16:44AM -0300, Jason Gunthorpe wrote: > On Mon, May 06, 2019 at 04:29:39PM -0700, rcampb...@nvidia.com wrote: > > From: Ralph Campbell > > > > There are no functional changes, just some coding style clean ups and > > minor comment changes. > > > > Signed-off-by: Ralph

Re: [PATCH 2/5] mm/hmm: Clean up some coding style and comments

2019-06-06 Thread Jason Gunthorpe
On Mon, May 06, 2019 at 04:29:39PM -0700, rcampb...@nvidia.com wrote: > From: Ralph Campbell > > There are no functional changes, just some coding style clean ups and > minor comment changes. > > Signed-off-by: Ralph Campbell > Reviewed-by: Jérôme Glisse > Cc: John Hubbard > Cc: Ira Weiny >

[PATCH 2/5] mm/hmm: Clean up some coding style and comments

2019-05-06 Thread rcampbell
From: Ralph Campbell There are no functional changes, just some coding style clean ups and minor comment changes. Signed-off-by: Ralph Campbell Cc: John Hubbard Cc: Ira Weiny Cc: Dan Williams Cc: Arnd Bergmann Cc: Balbir Singh Cc: Dan Carpenter Cc: Matthew Wilcox Cc: Souptick Joarder