Re: [PATCH 2/5] mm: migrate: Change migrate_mode to support combination migration modes.

2016-11-28 Thread Zi Yan
On 24 Nov 2016, at 3:15, Anshuman Khandual wrote: > On 11/22/2016 09:55 PM, Zi Yan wrote: >> From: Zi Yan >> >> From: Zi Yan >> >> No functionality is changed. > > The commit message need to contains more details like it changes > the enum declaration

Re: [PATCH 2/5] mm: migrate: Change migrate_mode to support combination migration modes.

2016-11-28 Thread Zi Yan
On 24 Nov 2016, at 3:15, Anshuman Khandual wrote: > On 11/22/2016 09:55 PM, Zi Yan wrote: >> From: Zi Yan >> >> From: Zi Yan >> >> No functionality is changed. > > The commit message need to contains more details like it changes > the enum declaration from numbers to bit positions, where all it

Re: [PATCH 2/5] mm: migrate: Change migrate_mode to support combination migration modes.

2016-11-24 Thread Balbir Singh
On 23/11/16 03:25, Zi Yan wrote: > From: Zi Yan > > From: Zi Yan > > No functionality is changed. I think you'd want to say that the modes are no longer exclusive. We can use them as flags in combination? Balbir Singh.

Re: [PATCH 2/5] mm: migrate: Change migrate_mode to support combination migration modes.

2016-11-24 Thread Balbir Singh
On 23/11/16 03:25, Zi Yan wrote: > From: Zi Yan > > From: Zi Yan > > No functionality is changed. I think you'd want to say that the modes are no longer exclusive. We can use them as flags in combination? Balbir Singh.

Re: [PATCH 2/5] mm: migrate: Change migrate_mode to support combination migration modes.

2016-11-24 Thread Anshuman Khandual
On 11/22/2016 09:55 PM, Zi Yan wrote: > From: Zi Yan > > From: Zi Yan > > No functionality is changed. The commit message need to contains more details like it changes the enum declaration from numbers to bit positions, where all it changes existing

Re: [PATCH 2/5] mm: migrate: Change migrate_mode to support combination migration modes.

2016-11-24 Thread Anshuman Khandual
On 11/22/2016 09:55 PM, Zi Yan wrote: > From: Zi Yan > > From: Zi Yan > > No functionality is changed. The commit message need to contains more details like it changes the enum declaration from numbers to bit positions, where all it changes existing code like compaction and migration. > >

[PATCH 2/5] mm: migrate: Change migrate_mode to support combination migration modes.

2016-11-22 Thread Zi Yan
From: Zi Yan From: Zi Yan No functionality is changed. Signed-off-by: Zi Yan Signed-off-by: Zi Yan --- include/linux/migrate_mode.h | 6 +++--- mm/compaction.c | 20 ++--

[PATCH 2/5] mm: migrate: Change migrate_mode to support combination migration modes.

2016-11-22 Thread Zi Yan
From: Zi Yan From: Zi Yan No functionality is changed. Signed-off-by: Zi Yan Signed-off-by: Zi Yan --- include/linux/migrate_mode.h | 6 +++--- mm/compaction.c | 20 ++-- mm/migrate.c | 14 +++--- 3 files changed, 20 insertions(+), 20