Re: [PATCH 2/5] netfilter: Fix format string mismatch in mangle_content_len()

2014-04-29 Thread Pablo Neira Ayuso
On Tue, Apr 29, 2014 at 03:21:21PM +0100, Patrick McHardy wrote: > On Tue, Apr 01, 2014 at 12:43:36AM +0900, Masanari Iida wrote: > > Fix format string mismatch in mangle_connect_len() > > All these patches seem like pointless noise to me. In none of these > cases can the value legitimately be

Re: [PATCH 2/5] netfilter: Fix format string mismatch in mangle_content_len()

2014-04-29 Thread Patrick McHardy
On Tue, Apr 01, 2014 at 12:43:36AM +0900, Masanari Iida wrote: > Fix format string mismatch in mangle_connect_len() All these patches seem like pointless noise to me. In none of these cases can the value legitimately be negative. If anything, you should fix the types to be unsigned. > >

Re: [PATCH 2/5] netfilter: Fix format string mismatch in mangle_content_len()

2014-04-29 Thread Patrick McHardy
On Tue, Apr 01, 2014 at 12:43:36AM +0900, Masanari Iida wrote: Fix format string mismatch in mangle_connect_len() All these patches seem like pointless noise to me. In none of these cases can the value legitimately be negative. If anything, you should fix the types to be unsigned.

Re: [PATCH 2/5] netfilter: Fix format string mismatch in mangle_content_len()

2014-04-29 Thread Pablo Neira Ayuso
On Tue, Apr 29, 2014 at 03:21:21PM +0100, Patrick McHardy wrote: On Tue, Apr 01, 2014 at 12:43:36AM +0900, Masanari Iida wrote: Fix format string mismatch in mangle_connect_len() All these patches seem like pointless noise to me. In none of these cases can the value legitimately be

[PATCH 2/5] netfilter: Fix format string mismatch in mangle_content_len()

2014-03-31 Thread Masanari Iida
Fix format string mismatch in mangle_connect_len() Signed-off-by: Masanari Iida --- net/netfilter/nf_nat_sip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_nat_sip.c b/net/netfilter/nf_nat_sip.c index b4d691d..5f98845 100644 ---

[PATCH 2/5] netfilter: Fix format string mismatch in mangle_content_len()

2014-03-31 Thread Masanari Iida
Fix format string mismatch in mangle_connect_len() Signed-off-by: Masanari Iida standby2...@gmail.com --- net/netfilter/nf_nat_sip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_nat_sip.c b/net/netfilter/nf_nat_sip.c index b4d691d..5f98845 100644 ---