Re: [PATCH 2/5] perf unwind: Do not look at globals

2018-01-17 Thread Jiri Olsa
On Tue, Jan 16, 2018 at 05:05:20PM -0300, Arnaldo Carvalho de Melo wrote: SNIP > > > > > > +/* > > > + * Are there any events usind DWARF callchains? > > > + * > > > + * I.e. > > > + * > > > + * -e cycles/call-graph=dwarf/ > > > + */ > > > +bool dwarf_callchain_users; > > > > hum, I don't foll

Re: [PATCH 2/5] perf unwind: Do not look at globals

2018-01-16 Thread Namhyung Kim
Hi Arnaldo, On Tue, Jan 16, 2018 at 05:05:20PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 16, 2018 at 08:49:09PM +0100, Jiri Olsa escreveu: > > On Tue, Jan 16, 2018 at 03:26:50PM -0300, Arnaldo Carvalho de Melo wrote: > > > > SNIP > > > > > diff --git a/tools/perf/builtin-c2c.c b/tools

Re: [PATCH 2/5] perf unwind: Do not look at globals

2018-01-16 Thread Arnaldo Carvalho de Melo
Em Tue, Jan 16, 2018 at 08:55:55PM +0100, Jiri Olsa escreveu: > On Tue, Jan 16, 2018 at 04:45:20PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jan 16, 2018 at 08:30:35PM +0100, Jiri Olsa escreveu: > > > On Tue, Jan 16, 2018 at 12:36:21PM -0300, Arnaldo Carvalho de Melo wrote: > > > > Em Tue,

Re: [PATCH 2/5] perf unwind: Do not look at globals

2018-01-16 Thread Arnaldo Carvalho de Melo
Em Tue, Jan 16, 2018 at 08:49:09PM +0100, Jiri Olsa escreveu: > On Tue, Jan 16, 2018 at 03:26:50PM -0300, Arnaldo Carvalho de Melo wrote: > > SNIP > > > diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c > > index c0debc3f79b6..c0815a37fdb5 100644 > > --- a/tools/perf/builtin-c2c.c

Re: [PATCH 2/5] perf unwind: Do not look at globals

2018-01-16 Thread Jiri Olsa
On Tue, Jan 16, 2018 at 04:45:20PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 16, 2018 at 08:30:35PM +0100, Jiri Olsa escreveu: > > On Tue, Jan 16, 2018 at 12:36:21PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Tue, Jan 16, 2018 at 04:19:15PM +0100, Jiri Olsa escreveu: > > > > On Tue,

Re: [PATCH 2/5] perf unwind: Do not look at globals

2018-01-16 Thread Jiri Olsa
On Tue, Jan 16, 2018 at 03:26:50PM -0300, Arnaldo Carvalho de Melo wrote: SNIP > diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c > index c0debc3f79b6..c0815a37fdb5 100644 > --- a/tools/perf/builtin-c2c.c > +++ b/tools/perf/builtin-c2c.c > @@ -2390,9 +2390,10 @@ static int setup_c

Re: [PATCH 2/5] perf unwind: Do not look at globals

2018-01-16 Thread Arnaldo Carvalho de Melo
Em Tue, Jan 16, 2018 at 08:30:35PM +0100, Jiri Olsa escreveu: > On Tue, Jan 16, 2018 at 12:36:21PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jan 16, 2018 at 04:19:15PM +0100, Jiri Olsa escreveu: > > > On Tue, Jan 16, 2018 at 11:24:35AM -0300, Arnaldo Carvalho de Melo wrote: > > > > > > SN

Re: [PATCH 2/5] perf unwind: Do not look at globals

2018-01-16 Thread Jiri Olsa
On Tue, Jan 16, 2018 at 12:36:21PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 16, 2018 at 04:19:15PM +0100, Jiri Olsa escreveu: > > On Tue, Jan 16, 2018 at 11:24:35AM -0300, Arnaldo Carvalho de Melo wrote: > > > > SNIP > > > > > Cc: Adrian Hunter > > > Cc: David Ahern > > > Cc: Hendri

Re: [PATCH 2/5] perf unwind: Do not look at globals

2018-01-16 Thread Arnaldo Carvalho de Melo
Em Tue, Jan 16, 2018 at 12:36:21PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Jan 16, 2018 at 04:19:15PM +0100, Jiri Olsa escreveu: > > it should get set in apply_config_terms which calls parse_callchain_record > No, it should not set the global parameter, as this is just for a > specifi

Re: [PATCH 2/5] perf unwind: Do not look at globals

2018-01-16 Thread Arnaldo Carvalho de Melo
Em Tue, Jan 16, 2018 at 04:19:15PM +0100, Jiri Olsa escreveu: > On Tue, Jan 16, 2018 at 11:24:35AM -0300, Arnaldo Carvalho de Melo wrote: > > SNIP > > > Cc: Adrian Hunter > > Cc: David Ahern > > Cc: Hendrick Brueckner > > Cc: Jiri Olsa > > Cc: Namhyung Kim > > Cc: Thomas Richter > > Cc: Wan

Re: [PATCH 2/5] perf unwind: Do not look at globals

2018-01-16 Thread Jiri Olsa
On Tue, Jan 16, 2018 at 11:24:35AM -0300, Arnaldo Carvalho de Melo wrote: SNIP > Cc: Adrian Hunter > Cc: David Ahern > Cc: Hendrick Brueckner > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Thomas Richter > Cc: Wang Nan > Link: https://lkml.kernel.org/n/tip-skbth8ufepbtw8xar7gds...@git.kernel.org

[PATCH 2/5] perf unwind: Do not look at globals

2018-01-16 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo When setting up DWARF callchains on specific events, without using 'record' or 'trace' --call-graph, but instead doing it like: perf trace -e cycles/call-graph=dwarf/ The unwind__prepare_access() call in thread__insert_map() when we process PERF_RECORD_MMA