Re: [PATCH 2/5] power_supply: charger-manager: add missing of_node_put

2015-10-15 Thread Sebastian Reichel
Hi, On Sat, Oct 10, 2015 at 02:30:51PM +0200, Julia Lawall wrote: > for_each_child_of_node performs an of_node_get on each iteration, so > a break out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > e

Re: [PATCH 2/5] power_supply: charger-manager: add missing of_node_put

2015-10-11 Thread Krzysztof Kozlowski
2015-10-10 21:30 GMT+09:00 Julia Lawall : > for_each_child_of_node performs an of_node_get on each iteration, so > a break out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > expression root,e; > local i

[PATCH 2/5] power_supply: charger-manager: add missing of_node_put

2015-10-10 Thread Julia Lawall
for_each_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; @@ for_each_child_of_node(root, child)