Re: [PATCH 2/5] regulator: s5m8767: Do not use sec_reg* regmap helpers

2013-12-18 Thread Mark Brown
On Tue, Dec 17, 2013 at 02:23:18PM +0100, Krzysztof Kozlowski wrote: > Replace calls to sec_reg* helpers with direct usage of regmap API. The > sec_reg* helpers are error-prone as they mix u8 with unsigned int and > order of some of parameters (val and mask in sec_reg_update()). Applied, thanks.

Re: [PATCH 2/5] regulator: s5m8767: Do not use sec_reg* regmap helpers

2013-12-17 Thread Lee Jones
On Tue, 17 Dec 2013, Krzysztof Kozlowski wrote: > Replace calls to sec_reg* helpers with direct usage of regmap API. The > sec_reg* helpers are error-prone as they mix u8 with unsigned int and > order of some of parameters (val and mask in sec_reg_update()). > > Also the helpers do not give any w

[PATCH 2/5] regulator: s5m8767: Do not use sec_reg* regmap helpers

2013-12-17 Thread Krzysztof Kozlowski
Replace calls to sec_reg* helpers with direct usage of regmap API. The sec_reg* helpers are error-prone as they mix u8 with unsigned int and order of some of parameters (val and mask in sec_reg_update()). Also the helpers do not give any way of useful abstraction as they just call corresponding re