Re: [PATCH 2/5] solos-pci: fix error return code

2014-08-07 Thread David Miller
From: Julia Lawall Date: Thu, 7 Aug 2014 14:49:07 +0200 > From: Julia Lawall > > Convert a zero return value on error to a negative one, as returned > elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows:

Re: [PATCH 2/5] solos-pci: fix error return code

2014-08-07 Thread chas williams - CONTRACTOR
On Thu, 7 Aug 2014 14:49:07 +0200 Julia Lawall wrote: ... > drivers/atm/solos-pci.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c > index 943cf0d..7652e8d 100644 > --- a/drivers/atm/solos-pci.c > +++ b/drivers/atm/solos-pci.c >

[PATCH 2/5] solos-pci: fix error return code

2014-08-07 Thread Julia Lawall
From: Julia Lawall Convert a zero return value on error to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret !=

[PATCH 2/5] solos-pci: fix error return code

2014-08-07 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr Convert a zero return value on error to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier ret; expression e1,e2; @@ (

Re: [PATCH 2/5] solos-pci: fix error return code

2014-08-07 Thread chas williams - CONTRACTOR
On Thu, 7 Aug 2014 14:49:07 +0200 Julia Lawall julia.law...@lip6.fr wrote: ... drivers/atm/solos-pci.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c index 943cf0d..7652e8d 100644 --- a/drivers/atm/solos-pci.c +++

Re: [PATCH 2/5] solos-pci: fix error return code

2014-08-07 Thread David Miller
From: Julia Lawall julia.law...@lip6.fr Date: Thu, 7 Aug 2014 14:49:07 +0200 From: Julia Lawall julia.law...@lip6.fr Convert a zero return value on error to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as