Re: [PATCH 2/5] soundwire: stream: add helper to startup/shutdown streams

2020-06-30 Thread Vinod Koul
On 30-06-20, 11:58, Pierre-Louis Bossart wrote: > > > +int sdw_startup_stream(void *sdw_substream) > > > > Can we have kernel doc style Documentation for exported APIs? > > yes, that's a miss indeed. > > Though if we follow the existing examples it's not going to be very > informative, e.g. Yea

Re: [PATCH 2/5] soundwire: stream: add helper to startup/shutdown streams

2020-06-30 Thread Pierre-Louis Bossart
Thanks Vinod for the review. --- a/drivers/soundwire/stream.c +++ b/drivers/soundwire/stream.c @@ -13,6 +13,9 @@ #include #include #include +#include Do we really need core header? No we don't, the only thing needed in sound/soc.h it seems. +#include +#include #include "bus.h

Re: [PATCH 2/5] soundwire: stream: add helper to startup/shutdown streams

2020-06-30 Thread Vinod Koul
On 23-06-20, 05:23, Bard Liao wrote: > From: Pierre-Louis Bossart > > To handle streams at the dailink level, expose two helpers that will > be called from machine drivers. > > Reviewed-by: Ranjani Sridharan > Reviewed-by: Guennadi Liakhovetski > Reviewed-by: Kai Vehmanen > Signed-off-by: Pie

[PATCH 2/5] soundwire: stream: add helper to startup/shutdown streams

2020-06-23 Thread Bard Liao
From: Pierre-Louis Bossart To handle streams at the dailink level, expose two helpers that will be called from machine drivers. Reviewed-by: Ranjani Sridharan Reviewed-by: Guennadi Liakhovetski Reviewed-by: Kai Vehmanen Signed-off-by: Pierre-Louis Bossart Signed-off-by: Bard Liao --- drive