Re: [PATCH 2/5] watchdog: move watchdog_disable_all_cpus() outside of ifdef

2015-09-29 Thread Andrew Morton
On Mon, 28 Sep 2015 22:44:09 +0200 Ulrich Obergfell wrote: > It makes sense to place watchdog_{dis|enable}_all_cpus() outside of > the ifdef so that _both_ are available even if CONFIG_SYSCTL is not > defined. Not really. With CONFIG_SYSCTL=n this change will cause a compile warning and will bl

Re: [PATCH 2/5] watchdog: move watchdog_disable_all_cpus() outside of ifdef

2015-09-28 Thread Aaron Tomlin
On Mon 2015-09-28 22:44 +0200, Ulrich Obergfell wrote: > It makes sense to place watchdog_{dis|enable}_all_cpus() outside of > the ifdef so that _both_ are available even if CONFIG_SYSCTL is not > defined. > > Signed-off-by: Ulrich Obergfell > --- > kernel/watchdog.c | 8 +--- > 1 file chang

[PATCH 2/5] watchdog: move watchdog_disable_all_cpus() outside of ifdef

2015-09-28 Thread Ulrich Obergfell
It makes sense to place watchdog_{dis|enable}_all_cpus() outside of the ifdef so that _both_ are available even if CONFIG_SYSCTL is not defined. Signed-off-by: Ulrich Obergfell --- kernel/watchdog.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/kernel/watchdog.c b/k