Re: [PATCH 2/5] x86_64 EFI support -v3: EFI boot support

2007-08-01 Thread Andi Kleen
> > Should I change "change_page_attr" to make it work before "mem_init"? Or > Should I change "init_memory_mapping" to make it can be used to change > mapping attributes? Which one is better? It's probably better to change init_memory_mapping. Just do it cleanly and correctly please. As in onl

Re: [PATCH 2/5] x86_64 EFI support -v3: EFI boot support

2007-08-01 Thread Huang, Ying
On Tue, 2007-07-31 at 13:35 +0200, Andi Kleen wrote: > > static unsigned long dma_reserve __initdata; > > +/* Flag indicating EFI runtime executable code area */ > > +static int efi_runtime_code_area; > > We don't normally use globals to modify function behaviour. > > > > > DEFINE_PER_CPU(str

Re: [PATCH 2/5] x86_64 EFI support -v3: EFI boot support

2007-07-31 Thread Andi Kleen
> static unsigned long dma_reserve __initdata; > +/* Flag indicating EFI runtime executable code area */ > +static int efi_runtime_code_area; We don't normally use globals to modify function behaviour. > > DEFINE_PER_CPU(struct mmu_gather, mmu_gathers); > > @@ -199,7 +202,7 @@ > static __

[PATCH 2/5] x86_64 EFI support -v3: EFI boot support

2007-07-30 Thread Huang, Ying
This patch adds boot support for EFI x86_64 system. Boot parameter setup file is updated for x86_64 EFI support. x86_64 EFI boot loader must conform to the EFI boot parameter offsets defined in the file include/asm-x86_64/bootsetup.h (and x86_64 patches submitted to ELILO bootloader conforms to th