Re: [PATCH 2/6] Add shared update_fdt() function for ARM/ARM64

2013-10-03 Thread Matt Fleming
On Thu, 03 Oct, at 12:28:03PM, Roy Franz wrote: > Hi Matt, > >This function is shared between ARM and ARM64, which are separate > architectures so to keep this in arch code would require it to be > duplicated for ARM/ARM64. Would moving this function to a new > "efi-stub-fdt.c" file be satis

Re: [PATCH 2/6] Add shared update_fdt() function for ARM/ARM64

2013-10-03 Thread Roy Franz
On Thu, Oct 3, 2013 at 7:27 AM, Matt Fleming wrote: > On Thu, 03 Oct, at 09:43:24AM, Mark Salter wrote: >> On Thu, 2013-10-03 at 10:52 +0100, Matt Fleming wrote: >> > > +#if defined(CONFIG_ARM) || defined(CONFIG_ARM64) >> > > +static efi_status_t update_fdt(efi_system_table_t *sys_table, void >>

Re: [PATCH 2/6] Add shared update_fdt() function for ARM/ARM64

2013-10-03 Thread Mark Salter
On Thu, 2013-10-03 at 15:27 +0100, Matt Fleming wrote: > On Thu, 03 Oct, at 09:43:24AM, Mark Salter wrote: > > On Thu, 2013-10-03 at 10:52 +0100, Matt Fleming wrote: > > > > +#if defined(CONFIG_ARM) || defined(CONFIG_ARM64) > > > > +static efi_status_t update_fdt(efi_system_table_t *sys_table, void

Re: [PATCH 2/6] Add shared update_fdt() function for ARM/ARM64

2013-10-03 Thread Matt Fleming
On Thu, 03 Oct, at 09:43:24AM, Mark Salter wrote: > On Thu, 2013-10-03 at 10:52 +0100, Matt Fleming wrote: > > > +#if defined(CONFIG_ARM) || defined(CONFIG_ARM64) > > > +static efi_status_t update_fdt(efi_system_table_t *sys_table, void > > > *orig_fdt, > > > +void *fdt

Re: [PATCH 2/6] Add shared update_fdt() function for ARM/ARM64

2013-10-03 Thread Mark Salter
On Thu, 2013-10-03 at 10:52 +0100, Matt Fleming wrote: > > +#if defined(CONFIG_ARM) || defined(CONFIG_ARM64) > > +static efi_status_t update_fdt(efi_system_table_t *sys_table, void > > *orig_fdt, > > +void *fdt, int new_fdt_size, char *cmdline_ptr, > > +

Re: [PATCH 2/6] Add shared update_fdt() function for ARM/ARM64

2013-10-03 Thread Matt Fleming
On Sat, 28 Sep, at 09:23:19AM, Roy Franz wrote: > Both ARM and ARM64 stubs will update the device tree > that they pass to the kernel. In both cases they > primarily need to add the same UEFI related information, > so the function can be shared. > > Signed-off-by: Roy Franz > --- > drivers/firm

[PATCH 2/6] Add shared update_fdt() function for ARM/ARM64

2013-09-28 Thread Roy Franz
Both ARM and ARM64 stubs will update the device tree that they pass to the kernel. In both cases they primarily need to add the same UEFI related information, so the function can be shared. Signed-off-by: Roy Franz --- drivers/firmware/efi/efi-stub-helper.c | 86 ++