Re: [PATCH 2/6] KVM: VMX: cleanup check for invalid EPT violation

2017-03-28 Thread Paolo Bonzini
On 09/03/2017 11:50, David Hildenbrand wrote: >> Do we have any define for this magic bit 7? >> >> #EPT_EXITQ_GLA_VALID 0x80 >> > Introducing > > #define EPT_VIOLATION_GLA_VALID_BIT > #define EPT_VIOLATION_GLA_VALID Done: diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h

Re: [PATCH 2/6] KVM: VMX: cleanup check for invalid EPT violation

2017-03-28 Thread Paolo Bonzini
On 09/03/2017 11:50, David Hildenbrand wrote: >> Do we have any define for this magic bit 7? >> >> #EPT_EXITQ_GLA_VALID 0x80 >> > Introducing > > #define EPT_VIOLATION_GLA_VALID_BIT > #define EPT_VIOLATION_GLA_VALID Done: diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h

Re: [PATCH 2/6] KVM: VMX: cleanup check for invalid EPT violation

2017-03-09 Thread David Hildenbrand
Am 09.03.2017 um 11:43 schrieb David Hildenbrand: > Am 08.03.2017 um 19:03 schrieb Paolo Bonzini: >> handle_ept_violation is checking for "guest-linear-address invalid" + >> "paging-structure walk", which is a sign of a bug in KVM. However, >> _all_ EPT violations without a valid guest linear

Re: [PATCH 2/6] KVM: VMX: cleanup check for invalid EPT violation

2017-03-09 Thread David Hildenbrand
Am 09.03.2017 um 11:43 schrieb David Hildenbrand: > Am 08.03.2017 um 19:03 schrieb Paolo Bonzini: >> handle_ept_violation is checking for "guest-linear-address invalid" + >> "paging-structure walk", which is a sign of a bug in KVM. However, >> _all_ EPT violations without a valid guest linear

Re: [PATCH 2/6] KVM: VMX: cleanup check for invalid EPT violation

2017-03-09 Thread David Hildenbrand
Am 08.03.2017 um 19:03 schrieb Paolo Bonzini: > handle_ept_violation is checking for "guest-linear-address invalid" + > "paging-structure walk", which is a sign of a bug in KVM. However, > _all_ EPT violations without a valid guest linear address are paging > structure walks, because those EPT

Re: [PATCH 2/6] KVM: VMX: cleanup check for invalid EPT violation

2017-03-09 Thread David Hildenbrand
Am 08.03.2017 um 19:03 schrieb Paolo Bonzini: > handle_ept_violation is checking for "guest-linear-address invalid" + > "paging-structure walk", which is a sign of a bug in KVM. However, > _all_ EPT violations without a valid guest linear address are paging > structure walks, because those EPT

[PATCH 2/6] KVM: VMX: cleanup check for invalid EPT violation

2017-03-08 Thread Paolo Bonzini
handle_ept_violation is checking for "guest-linear-address invalid" + "paging-structure walk", which is a sign of a bug in KVM. However, _all_ EPT violations without a valid guest linear address are paging structure walks, because those EPT violations happen when loading the guest PDPTEs. So

[PATCH 2/6] KVM: VMX: cleanup check for invalid EPT violation

2017-03-08 Thread Paolo Bonzini
handle_ept_violation is checking for "guest-linear-address invalid" + "paging-structure walk", which is a sign of a bug in KVM. However, _all_ EPT violations without a valid guest linear address are paging structure walks, because those EPT violations happen when loading the guest PDPTEs. So