Re: [PATCH 2/6] arch: x86: Wrap TIF_IA32 checks

2020-07-29 Thread Gabriel Krisman Bertazi
Andy Lutomirski writes: > On Tue, Jul 28, 2020 at 9:46 PM Gabriel Krisman Bertazi > wrote: >> >> Andy Lutomirski writes: >> >> > On Tue, Jul 28, 2020 at 1:22 PM Gabriel Krisman Bertazi >> > wrote: >> >> >> >> In preparation to remove TIF_IA32, add wrapper that check the process >> >> has IA32

Re: [PATCH 2/6] arch: x86: Wrap TIF_IA32 checks

2020-07-29 Thread peterz
On Tue, Jul 28, 2020 at 08:43:27PM -0700, Andy Lutomirski wrote: > On Tue, Jul 28, 2020 at 1:22 PM Gabriel Krisman Bertazi > > diff --git a/arch/x86/events/intel/ds.c b/arch/x86/events/intel/ds.c > > index dc43cc124e09..27d1cc1f3d05 100644 > > --- a/arch/x86/events/intel/ds.c > > +++ b/arch/x86/ev

Re: [PATCH 2/6] arch: x86: Wrap TIF_IA32 checks

2020-07-29 Thread Christoph Hellwig
On Tue, Jul 28, 2020 at 08:43:27PM -0700, Andy Lutomirski wrote: > > index d4edf281fff4..d39f9b3ae683 100644 > > --- a/arch/x86/include/asm/compat.h > > +++ b/arch/x86/include/asm/compat.h > > @@ -181,7 +181,7 @@ static inline void __user > > *arch_compat_alloc_user_space(long len) > > { > >

Re: [PATCH 2/6] arch: x86: Wrap TIF_IA32 checks

2020-07-28 Thread Andy Lutomirski
On Tue, Jul 28, 2020 at 9:46 PM Gabriel Krisman Bertazi wrote: > > Andy Lutomirski writes: > > > On Tue, Jul 28, 2020 at 1:22 PM Gabriel Krisman Bertazi > > wrote: > >> > >> In preparation to remove TIF_IA32, add wrapper that check the process > >> has IA32 ABI without using the flag directly. >

Re: [PATCH 2/6] arch: x86: Wrap TIF_IA32 checks

2020-07-28 Thread Gabriel Krisman Bertazi
Andy Lutomirski writes: > On Tue, Jul 28, 2020 at 1:22 PM Gabriel Krisman Bertazi > wrote: >> >> In preparation to remove TIF_IA32, add wrapper that check the process >> has IA32 ABI without using the flag directly. > > Thank you for doing this, but let's please do it right. There is, > fundame

Re: [PATCH 2/6] arch: x86: Wrap TIF_IA32 checks

2020-07-28 Thread Andy Lutomirski
On Tue, Jul 28, 2020 at 1:22 PM Gabriel Krisman Bertazi wrote: > > In preparation to remove TIF_IA32, add wrapper that check the process > has IA32 ABI without using the flag directly. Thank you for doing this, but let's please do it right. There is, fundamentally, no such thing as a "process wi

[PATCH 2/6] arch: x86: Wrap TIF_IA32 checks

2020-07-28 Thread Gabriel Krisman Bertazi
In preparation to remove TIF_IA32, add wrapper that check the process has IA32 ABI without using the flag directly. Signed-off-by: Gabriel Krisman Bertazi --- arch/x86/events/core.c | 2 +- arch/x86/events/intel/ds.c | 2 +- arch/x86/events/intel/lbr.c| 2 +- arch/x86