Re: [PATCH 2/6] cpufreq: schedutil: ignore the sugov kthread for frequencies selections

2017-03-15 Thread Patrick Bellasi
On 06-Mar 09:35, Steven Rostedt wrote: > On Thu, 2 Mar 2017 15:45:03 + > Patrick Bellasi wrote: > > > @@ -287,6 +289,10 @@ static void sugov_update_shared(struct > > update_util_data *hook, u64 time, > > goto done; > > } > > > > + /* Skip updates generated by sugov kthr

Re: [PATCH 2/6] cpufreq: schedutil: ignore the sugov kthread for frequencies selections

2017-03-06 Thread Steven Rostedt
On Thu, 2 Mar 2017 15:45:03 + Patrick Bellasi wrote: > @@ -287,6 +289,10 @@ static void sugov_update_shared(struct update_util_data > *hook, u64 time, > goto done; > } > > + /* Skip updates generated by sugov kthreads */ > + if (curr == sg_policy->thread) I t

Re: [PATCH 2/6] cpufreq: schedutil: ignore the sugov kthread for frequencies selections

2017-03-05 Thread Viresh Kumar
On 03-03-17, 12:12, Patrick Bellasi wrote: > On 03-Mar 10:49, Viresh Kumar wrote: > > I always wanted to avoid such hacks when I moved to the RT thread :( > > Indeed, it is a bit of an hack... but still it's true that this is a > "special" RT thread which must not bias OPP selection. I agree. We

Re: [PATCH 2/6] cpufreq: schedutil: ignore the sugov kthread for frequencies selections

2017-03-03 Thread Patrick Bellasi
On 03-Mar 10:49, Viresh Kumar wrote: > On 02-03-17, 15:45, Patrick Bellasi wrote: > > In system where multiple CPUs shares the same frequency domain a small > > workload on a CPU can still be subject frequency spikes, generated by > > the activation of the sugov's kthread. > > > > Since the sugov

Re: [PATCH 2/6] cpufreq: schedutil: ignore the sugov kthread for frequencies selections

2017-03-02 Thread Viresh Kumar
On 02-03-17, 15:45, Patrick Bellasi wrote: > In system where multiple CPUs shares the same frequency domain a small > workload on a CPU can still be subject frequency spikes, generated by > the activation of the sugov's kthread. > > Since the sugov kthread is a special RT task, which goal is just

[PATCH 2/6] cpufreq: schedutil: ignore the sugov kthread for frequencies selections

2017-03-02 Thread Patrick Bellasi
In system where multiple CPUs shares the same frequency domain a small workload on a CPU can still be subject frequency spikes, generated by the activation of the sugov's kthread. Since the sugov kthread is a special RT task, which goal is just that to activate a frequency transition, it does not