Re: [PATCH 2/6] e1000: use pcix_set_mmrbc

2006-12-08 Thread Jeff Kirsher
On 12/8/06, Auke Kok <[EMAIL PROTECTED]> wrote: Stephen Hemminger wrote: > On Fri, 08 Dec 2006 13:45:05 -0800 > > Hmm.. looks like all that code should really be moved off to PCI bus > quirk/setup. None of it is E1000 specific. Something like this (untested): This is not true, and I have to NA

Re: [PATCH 2/6] e1000: use pcix_set_mmrbc

2006-12-08 Thread Auke Kok
Stephen Hemminger wrote: On Fri, 08 Dec 2006 13:45:05 -0800 Roland Dreier <[EMAIL PROTECTED]> wrote: > -if (hw->bus_type == e1000_bus_type_pcix) { > -e1000_read_pci_cfg(hw, PCIX_COMMAND_REGISTER, &pcix_cmd_word); > -e1000_read_pci_cfg(hw, PCIX_STATUS_REGISTER_

Re: [PATCH 2/6] e1000: use pcix_set_mmrbc

2006-12-08 Thread Stephen Hemminger
On Fri, 08 Dec 2006 13:45:05 -0800 Roland Dreier <[EMAIL PROTECTED]> wrote: > > -if (hw->bus_type == e1000_bus_type_pcix) { > > -e1000_read_pci_cfg(hw, PCIX_COMMAND_REGISTER, &pcix_cmd_word); > > -e1000_read_pci_cfg(hw, PCIX_STATUS_REGISTER_HI, > > -

Re: [PATCH 2/6] e1000: use pcix_set_mmrbc

2006-12-08 Thread Roland Dreier
> -if (hw->bus_type == e1000_bus_type_pcix) { > -e1000_read_pci_cfg(hw, PCIX_COMMAND_REGISTER, &pcix_cmd_word); > -e1000_read_pci_cfg(hw, PCIX_STATUS_REGISTER_HI, > -&pcix_stat_hi_word); > -cmd_mmrbc = (pcix_cmd_word & PCIX_COMMAND_MM

[PATCH 2/6] e1000: use pcix_set_mmrbc

2006-12-08 Thread Stephen Hemminger
Use new pcix_set_mmrbc interface, this prevents possible data corruption on broken PCI-X chipsets. The E1000 PCI hardware wrappers are a nuisance. Untested on real hardware. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_hw.c | 23 ++- d