Kristian Høgsberg wrote:
> Christoph Hellwig wrote:
[...]
>>> + retval = fw_core_add_descriptor(_id_descriptor);
>>> + BUG_ON(retval < 0);
>>
>> These kinds of bug checks look wrong. Either the operations
>> can't fail in which case they should not return an error value
>> or you should
Kristian Høgsberg wrote:
Christoph Hellwig wrote:
[...]
+ retval = fw_core_add_descriptor(model_id_descriptor);
+ BUG_ON(retval 0);
These kinds of bug checks look wrong. Either the operations
can't fail in which case they should not return an error value
or you should handle them
Christoph Hellwig wrote:
+ for (i = 0; i < buffer->page_count; i++) {
+ buffer->pages[i] = alloc_page(GFP_KERNEL | GFP_DMA32 |
__GFP_ZERO);
+ if (buffer->pages[i] == NULL)
+ goto out_pages;
+
+ address =
> + for (i = 0; i < buffer->page_count; i++) {
> + buffer->pages[i] = alloc_page(GFP_KERNEL | GFP_DMA32 |
> __GFP_ZERO);
> + if (buffer->pages[i] == NULL)
> + goto out_pages;
> +
> + address = dma_map_page(card->device, buffer->pages[i],
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
drivers/firewire/fw-iso.c | 163 +
drivers/firewire/fw-transaction.c | 889 ++
drivers/firewire/fw-transaction.h | 505 +
3 files changed, 1557 insertions(+)
Index:
Signed-off-by: Stefan Richter [EMAIL PROTECTED]
---
drivers/firewire/fw-iso.c | 163 +
drivers/firewire/fw-transaction.c | 889 ++
drivers/firewire/fw-transaction.h | 505 +
3 files changed, 1557 insertions(+)
Index:
+ for (i = 0; i buffer-page_count; i++) {
+ buffer-pages[i] = alloc_page(GFP_KERNEL | GFP_DMA32 |
__GFP_ZERO);
+ if (buffer-pages[i] == NULL)
+ goto out_pages;
+
+ address = dma_map_page(card-device, buffer-pages[i],
+
Christoph Hellwig wrote:
+ for (i = 0; i buffer-page_count; i++) {
+ buffer-pages[i] = alloc_page(GFP_KERNEL | GFP_DMA32 |
__GFP_ZERO);
+ if (buffer-pages[i] == NULL)
+ goto out_pages;
+
+ address = dma_map_page(card-device,
8 matches
Mail list logo