Re: [PATCH 2/6] pci: Scan all functions when probing while running over Jailhouse

2018-02-27 Thread Andy Shevchenko
On Tue, Feb 27, 2018 at 9:22 AM, Jan Kiszka wrote: > On 2018-02-23 14:23, Andy Shevchenko wrote: >> On Mon, Jan 22, 2018 at 8:12 AM, Jan Kiszka wrote: >>> #include >>> #include >>> #include >>> +#include >> >> Ditto. >> > > Despite the context suggesting it, this file has no ordering. At

Re: [PATCH 2/6] pci: Scan all functions when probing while running over Jailhouse

2018-02-26 Thread Jan Kiszka
On 2018-02-22 21:57, Bjorn Helgaas wrote: > On Mon, Jan 22, 2018 at 07:12:46AM +0100, Jan Kiszka wrote: >> From: Jan Kiszka >> >> PCI and PCIBIOS probing only scans devices at function number 0/8/16/... >> Subdevices (e.g. multiqueue) have function numbers which are not a >> multiple of 8. > > Su

Re: [PATCH 2/6] pci: Scan all functions when probing while running over Jailhouse

2018-02-26 Thread Jan Kiszka
On 2018-02-23 14:23, Andy Shevchenko wrote: > On Mon, Jan 22, 2018 at 8:12 AM, Jan Kiszka wrote: > >> #include >> #include >> #include >> +#include > > Keep it in order? > Done. > >> #include >> #include >> #include >> +#include > > Ditto. > Despite the context suggesting it

Re: [PATCH 2/6] pci: Scan all functions when probing while running over Jailhouse

2018-02-23 Thread Andy Shevchenko
On Mon, Jan 22, 2018 at 8:12 AM, Jan Kiszka wrote: > #include > #include > #include > +#include Keep it in order? > #include > #include > #include > +#include Ditto. -- With Best Regards, Andy Shevchenko

Re: [PATCH 2/6] pci: Scan all functions when probing while running over Jailhouse

2018-02-22 Thread Bjorn Helgaas
On Mon, Jan 22, 2018 at 07:12:46AM +0100, Jan Kiszka wrote: > From: Jan Kiszka > > PCI and PCIBIOS probing only scans devices at function number 0/8/16/... > Subdevices (e.g. multiqueue) have function numbers which are not a > multiple of 8. Suggested text: Per PCIe r4.0, sec 7.5.1.1.9, multi

[PATCH 2/6] pci: Scan all functions when probing while running over Jailhouse

2018-01-21 Thread Jan Kiszka
From: Jan Kiszka PCI and PCIBIOS probing only scans devices at function number 0/8/16/... Subdevices (e.g. multiqueue) have function numbers which are not a multiple of 8. The simple hypervisor Jailhouse passes subdevices directly w/o providing a virtual PCI topology like KVM. As a consequence a