[PATCH 2/6] tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer

2021-01-21 Thread Greg Kroah-Hartman
From: Linus Torvalds The tty line discipline .read() function was passed the final user pointer destination as an argument, which doesn't match the 'write()' function, and makes it very inconvenient to do a splice method for ttys. This is a conversion to use a kernel buffer instead. NOTE! It do

Re: [PATCH 2/6] tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer

2021-01-21 Thread Jiri Slaby
On 21. 01. 21, 10:00, Greg Kroah-Hartman wrote: From: Linus Torvalds The tty line discipline .read() function was passed the final user pointer destination as an argument, which doesn't match the 'write()' function, and makes it very inconvenient to do a splice method for ttys. This is a conve

Re: [PATCH 2/6] tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer

2021-01-21 Thread Linus Torvalds
On Thu, Jan 21, 2021 at 3:02 AM Jiri Slaby wrote: > > n_hdlc_tty_read will return EOVERFLOW when size is 0, so this EFAULT is > never propagated, if I am looking correctly? n_tty seems to be fine > (returns zero for zeroed size). I'll fix that up too. Greg - same question - do you want an increm

Re: [PATCH 2/6] tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer

2021-01-21 Thread Greg Kroah-Hartman
On Thu, Jan 21, 2021 at 09:46:58AM -0800, Linus Torvalds wrote: > On Thu, Jan 21, 2021 at 3:02 AM Jiri Slaby wrote: > > > > n_hdlc_tty_read will return EOVERFLOW when size is 0, so this EFAULT is > > never propagated, if I am looking correctly? n_tty seems to be fine > > (returns zero for zeroed s