Re: [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-10-09 Thread Konrad Rzeszutek Wilk
On Fri, Oct 05, 2012 at 04:57:36PM +0100, David Vrabel wrote: > On 05/10/12 12:55, Jan Beulich wrote: > On 05.10.12 at 13:42, David Vrabel wrote: > >> On 02/10/12 21:02, Konrad Rzeszutek Wilk wrote: > >>> On Mon, Oct 01, 2012 at 06:19:19PM +0100, David Vrabel wrote: > On 25/09/12 18:53,

Re: [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-10-09 Thread Konrad Rzeszutek Wilk
On Fri, Oct 05, 2012 at 04:57:36PM +0100, David Vrabel wrote: On 05/10/12 12:55, Jan Beulich wrote: On 05.10.12 at 13:42, David Vrabel david.vra...@citrix.com wrote: On 02/10/12 21:02, Konrad Rzeszutek Wilk wrote: On Mon, Oct 01, 2012 at 06:19:19PM +0100, David Vrabel wrote: On 25/09/12

Re: [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-10-05 Thread David Vrabel
On 05/10/12 12:55, Jan Beulich wrote: On 05.10.12 at 13:42, David Vrabel wrote: >> On 02/10/12 21:02, Konrad Rzeszutek Wilk wrote: >>> On Mon, Oct 01, 2012 at 06:19:19PM +0100, David Vrabel wrote: On 25/09/12 18:53, David Vrabel wrote: > On 21/09/12 17:04, David Vrabel wrote: >>

Re: [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-10-05 Thread Jan Beulich
>>> On 05.10.12 at 13:42, David Vrabel wrote: > On 02/10/12 21:02, Konrad Rzeszutek Wilk wrote: >> On Mon, Oct 01, 2012 at 06:19:19PM +0100, David Vrabel wrote: >>> On 25/09/12 18:53, David Vrabel wrote: On 21/09/12 17:04, David Vrabel wrote: > From: David Vrabel > > Backend

Re: [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-10-05 Thread David Vrabel
On 02/10/12 21:02, Konrad Rzeszutek Wilk wrote: > On Mon, Oct 01, 2012 at 06:19:19PM +0100, David Vrabel wrote: >> On 25/09/12 18:53, David Vrabel wrote: >>> On 21/09/12 17:04, David Vrabel wrote: From: David Vrabel Backend drivers shouldn't transistion to CLOSED unless the

Re: [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-10-05 Thread David Vrabel
On 02/10/12 21:02, Konrad Rzeszutek Wilk wrote: On Mon, Oct 01, 2012 at 06:19:19PM +0100, David Vrabel wrote: On 25/09/12 18:53, David Vrabel wrote: On 21/09/12 17:04, David Vrabel wrote: From: David Vrabel david.vra...@citrix.com Backend drivers shouldn't transistion to CLOSED unless the

Re: [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-10-05 Thread Jan Beulich
On 05.10.12 at 13:42, David Vrabel david.vra...@citrix.com wrote: On 02/10/12 21:02, Konrad Rzeszutek Wilk wrote: On Mon, Oct 01, 2012 at 06:19:19PM +0100, David Vrabel wrote: On 25/09/12 18:53, David Vrabel wrote: On 21/09/12 17:04, David Vrabel wrote: From: David Vrabel

Re: [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-10-05 Thread David Vrabel
On 05/10/12 12:55, Jan Beulich wrote: On 05.10.12 at 13:42, David Vrabel david.vra...@citrix.com wrote: On 02/10/12 21:02, Konrad Rzeszutek Wilk wrote: On Mon, Oct 01, 2012 at 06:19:19PM +0100, David Vrabel wrote: On 25/09/12 18:53, David Vrabel wrote: On 21/09/12 17:04, David Vrabel wrote:

Re: [Xen-devel] [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-10-04 Thread David Vrabel
On 04/10/12 11:14, Jan Beulich wrote: On 25.09.12 at 19:53, David Vrabel wrote: >> @@ -1167,7 +1168,8 @@ blkfront_closing(struct blkfront_info *info) >> >> mutex_lock(>bd_mutex); >> >> -if (bdev->bd_openers) { >> +/* If the backend is already CLOSED, close now. */ >> +if

Re: [Xen-devel] [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-10-04 Thread Jan Beulich
>>> On 25.09.12 at 19:53, David Vrabel wrote: > @@ -1167,7 +1168,8 @@ blkfront_closing(struct blkfront_info *info) > > mutex_lock(>bd_mutex); > > - if (bdev->bd_openers) { > + /* If the backend is already CLOSED, close now. */ > + if (bdev->bd_openers && backend_state !=

Re: [Xen-devel] [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-10-04 Thread Jan Beulich
On 25.09.12 at 19:53, David Vrabel david.vra...@citrix.com wrote: @@ -1167,7 +1168,8 @@ blkfront_closing(struct blkfront_info *info) mutex_lock(bdev-bd_mutex); - if (bdev-bd_openers) { + /* If the backend is already CLOSED, close now. */ + if (bdev-bd_openers

Re: [Xen-devel] [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-10-04 Thread David Vrabel
On 04/10/12 11:14, Jan Beulich wrote: On 25.09.12 at 19:53, David Vrabel david.vra...@citrix.com wrote: @@ -1167,7 +1168,8 @@ blkfront_closing(struct blkfront_info *info) mutex_lock(bdev-bd_mutex); -if (bdev-bd_openers) { +/* If the backend is already CLOSED, close now. */

Re: [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-10-02 Thread Konrad Rzeszutek Wilk
On Mon, Oct 01, 2012 at 06:19:19PM +0100, David Vrabel wrote: > On 25/09/12 18:53, David Vrabel wrote: > > On 21/09/12 17:04, David Vrabel wrote: > >> From: David Vrabel > >> > >> Backend drivers shouldn't transistion to CLOSED unless the frontend is > >> CLOSED. If a backend does transition to

Re: [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-10-02 Thread Konrad Rzeszutek Wilk
On Mon, Oct 01, 2012 at 06:19:19PM +0100, David Vrabel wrote: On 25/09/12 18:53, David Vrabel wrote: On 21/09/12 17:04, David Vrabel wrote: From: David Vrabel david.vra...@citrix.com Backend drivers shouldn't transistion to CLOSED unless the frontend is CLOSED. If a backend does

Re: [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-10-01 Thread David Vrabel
On 25/09/12 18:53, David Vrabel wrote: > On 21/09/12 17:04, David Vrabel wrote: >> From: David Vrabel >> >> Backend drivers shouldn't transistion to CLOSED unless the frontend is >> CLOSED. If a backend does transition to CLOSED too soon then the >> frontend may not see the CLOSING state and

Re: [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-10-01 Thread David Vrabel
On 25/09/12 18:53, David Vrabel wrote: On 21/09/12 17:04, David Vrabel wrote: From: David Vrabel david.vra...@citrix.com Backend drivers shouldn't transistion to CLOSED unless the frontend is CLOSED. If a backend does transition to CLOSED too soon then the frontend may not see the CLOSING

Re: [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-09-25 Thread David Vrabel
On 21/09/12 17:04, David Vrabel wrote: > From: David Vrabel > > Backend drivers shouldn't transistion to CLOSED unless the frontend is > CLOSED. If a backend does transition to CLOSED too soon then the > frontend may not see the CLOSING state and will not properly shutdown. > > So, treat an

Re: [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-09-25 Thread David Vrabel
On 21/09/12 17:04, David Vrabel wrote: From: David Vrabel david.vra...@citrix.com Backend drivers shouldn't transistion to CLOSED unless the frontend is CLOSED. If a backend does transition to CLOSED too soon then the frontend may not see the CLOSING state and will not properly shutdown.

[PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-09-21 Thread David Vrabel
From: David Vrabel Backend drivers shouldn't transistion to CLOSED unless the frontend is CLOSED. If a backend does transition to CLOSED too soon then the frontend may not see the CLOSING state and will not properly shutdown. So, treat an unexpected backend CLOSED state the same as CLOSING.

[PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

2012-09-21 Thread David Vrabel
From: David Vrabel david.vra...@citrix.com Backend drivers shouldn't transistion to CLOSED unless the frontend is CLOSED. If a backend does transition to CLOSED too soon then the frontend may not see the CLOSING state and will not properly shutdown. So, treat an unexpected backend CLOSED state