On 3/21/07, Johannes Weiner <[EMAIL PROTECTED]> wrote:
Hi,
On Wed, Mar 21, 2007 at 09:49:12AM -0700, Wink Saville wrote:
> >>Please don't use camel-case - in general.
> >>
> Would p_next, p_cur and p_end be OK?
I think it's generally disliked. Quoting Documentation/CodingStyle:
``Encoding the
Hi,
On Wed, Mar 21, 2007 at 09:49:12AM -0700, Wink Saville wrote:
> >>Please don't use camel-case - in general.
> >>
> Would p_next, p_cur and p_end be OK?
I think it's generally disliked. Quoting Documentation/CodingStyle:
``Encoding the type of a function into the name (so-called Hungarian
Johannes Weiner wrote:
Your patch has broken lines where there shouldn't be any.
OK.
+ struct trec_buffer_struct * pNext;
+ struct trec_struct *pCur;
+ struct trec_struct *pEnd;
Please don't use camel-case - in general.
Would p_next, p_cur
Hi,
On Wed, Mar 21, 2007 at 09:22:39AM +0100, Johannes Weiner wrote:
> Your patch has broken lines where there shouldn't be any.
I mean, the attached patch. This is probably not an error in the patch
but in the way of posting it.
> > +static int snprint_address(char *b, int bsize, unsigned long
Hi,
On Tue, Mar 20, 2007 at 11:47:35PM -0700, Wink Saville wrote:
> --- /dev/null
> +++ b/drivers/trec/trec.c
> [...]
> +struct trec_dev_struct
> +{
> + struct cdevcdev; /* Character device
> structure */
Your patch has broken lines where there shouldn't be any
Signed-off-by: Wink Saville <[EMAIL PROTECTED]>
---
drivers/trec/Kconfig | 14 ++
drivers/trec/Makefile |5 +
drivers/trec/trec.c| 328
include/asm-generic/trec.h | 17 +++
include/asm-i386/trec.h| 33 +
include/asm-x86_
6 matches
Mail list logo
