Re: [PATCH 2/7] Input: psmouse - clean up code

2018-06-25 Thread Dmitry Torokhov
On Mon, Jun 25, 2018 at 08:35:14PM +0200, Jiri Slaby wrote: > On 01/20/2018, 12:06 AM, Dmitry Torokhov wrote: > > - switch to using BIT() macros > > - use u8 instead of unsigned char for byte data > > - use input_set_capability() instead of manipulating capabilities bits > > directly > > - use si

Re: [PATCH 2/7] Input: psmouse - clean up code

2018-06-25 Thread Jiri Slaby
On 01/20/2018, 12:06 AM, Dmitry Torokhov wrote: > - switch to using BIT() macros > - use u8 instead of unsigned char for byte data > - use input_set_capability() instead of manipulating capabilities bits > directly > - use sign_extend32() when extracting wheel data. > - do not abuse -1 as error c

[PATCH 2/7] Input: psmouse - clean up code

2018-01-19 Thread Dmitry Torokhov
- switch to using BIT() macros - use u8 instead of unsigned char for byte data - use input_set_capability() instead of manipulating capabilities bits directly - use sign_extend32() when extracting wheel data. - do not abuse -1 as error code, propagate errors from various calls. Signed-off-by: Dm