Re: [PATCH 2/7] MIPS: SGI-IP27: clean up bridge access and header files

2019-01-28 Thread Christoph Hellwig
On Mon, Jan 28, 2019 at 02:24:40PM +0100, Thomas Bogendoerfer wrote: > I totally agreed. I only moved the original defintion around while cleaning > up the header file. Right now there is no code using it. Should I remove it > and access macros as soon there is a need for it ? Sounds good.

Re: [PATCH 2/7] MIPS: SGI-IP27: clean up bridge access and header files

2019-01-28 Thread Thomas Bogendoerfer
On Mon, 28 Jan 2019 05:20:03 -0800 Christoph Hellwig wrote: > On Thu, Jan 24, 2019 at 06:47:23PM +0100, Thomas Bogendoerfer wrote: > > #ifndef __ASSEMBLY__ > > +/* Address translation entry for mapped pci32 accesses */ > > +union bridge_ate { > > + u64 ent; > > + struct ate_s { > > +

Re: [PATCH 2/7] MIPS: SGI-IP27: clean up bridge access and header files

2019-01-28 Thread Christoph Hellwig
On Thu, Jan 24, 2019 at 06:47:23PM +0100, Thomas Bogendoerfer wrote: > #ifndef __ASSEMBLY__ > +/* Address translation entry for mapped pci32 accesses */ > +union bridge_ate { > + u64 ent; > + struct ate_s { > + u64 rmf:16; > + u64 addr:36; > +

[PATCH 2/7] MIPS: SGI-IP27: clean up bridge access and header files

2019-01-24 Thread Thomas Bogendoerfer
Introduced bridge_read/bridge_write/bridge_set/bridge_clr for accessing bridge register and get rid of volatile declarations. Also removed all typedefs from arch/mips/include/asm/pci/bridge.h and cleaned up language in arch/mips/pci/ops-bridge.c Signed-off-by: Thomas Bogendoerfer ---