Re: [PATCH 2/7] PCI: move resources and bus_list releasing to pci_release_dev

2013-05-13 Thread Yijing Wang
On 2013/5/14 11:56, Yinghai Lu wrote: > On Mon, May 13, 2013 at 8:20 PM, Yijing Wang wrote: >> On 2013/5/14 10:28, Yinghai Lu wrote: >>> We should not release resource in pci_destroy that is too early >> >> Hi Yinghai, >>"too early" means that after pci_stop_dev(), if someone else >> hold the

Re: [PATCH 2/7] PCI: move resources and bus_list releasing to pci_release_dev

2013-05-13 Thread Yinghai Lu
On Mon, May 13, 2013 at 8:20 PM, Yijing Wang wrote: > On 2013/5/14 10:28, Yinghai Lu wrote: >> We should not release resource in pci_destroy that is too early > > Hi Yinghai, >"too early" means that after pci_stop_dev(), if someone else > hold the device reference, it still care the device res

Re: [PATCH 2/7] PCI: move resources and bus_list releasing to pci_release_dev

2013-05-13 Thread Yijing Wang
On 2013/5/14 10:28, Yinghai Lu wrote: > We should not release resource in pci_destroy that is too early Hi Yinghai, "too early" means that after pci_stop_dev(), if someone else hold the device reference, it still care the device resource ? e.g.? Thanks! Yijing. > as there could be still other

[PATCH 2/7] PCI: move resources and bus_list releasing to pci_release_dev

2013-05-13 Thread Yinghai Lu
We should not release resource in pci_destroy that is too early as there could be still other use hold reference. release them or remove it from bus devices list at last in pci_release_dev instead. Signed-off-by: Yinghai Lu --- drivers/pci/probe.c | 20 drivers/pci/remo