Re: [PATCH 2/7] cxgb3 - fix netpoll hanlder

2007-05-30 Thread Jeremy Fitzhardinge
Jeff Garzik wrote: > Look at the function argument... Yes, it's void *. But my point is that C requires the ?: to evaluate to some specific type, so if you have different types on each side of the : the compiler can be legitimately upset. The fact that the whole thing gets cast to void * is

Re: [PATCH 2/7] cxgb3 - fix netpoll hanlder

2007-05-30 Thread Jeremy Fitzhardinge
Jeff Garzik wrote: Look at the function argument... Yes, it's void *. But my point is that C requires the ?: to evaluate to some specific type, so if you have different types on each side of the : the compiler can be legitimately upset. The fact that the whole thing gets cast to void * is

Re: [PATCH 2/7] cxgb3 - fix netpoll hanlder

2007-05-29 Thread Jeff Garzik
Jeremy Fitzhardinge wrote: Jeff Garzik wrote: +t3_intr_handler(adapter, qs->rspq.polling) (0, +(adapter->flags & USING_MSIX) ? +(void *)qs : (void *)adapter); Remove needless casts to void* The two branches of ?: need to have the same type;

Re: [PATCH 2/7] cxgb3 - fix netpoll hanlder

2007-05-29 Thread Jeremy Fitzhardinge
Jeff Garzik wrote: >> >> +t3_intr_handler(adapter, qs->rspq.polling) (0, >> +(adapter->flags & USING_MSIX) ? >> +(void *)qs : (void *)adapter); > > Remove needless casts to void* The two branches of ?: need to have the same type; without the casts

Re: [PATCH 2/7] cxgb3 - fix netpoll hanlder

2007-05-29 Thread Jeremy Fitzhardinge
Jeff Garzik wrote: +t3_intr_handler(adapter, qs-rspq.polling) (0, +(adapter-flags USING_MSIX) ? +(void *)qs : (void *)adapter); Remove needless casts to void* The two branches of ?: need to have the same type; without the casts they'd be

Re: [PATCH 2/7] cxgb3 - fix netpoll hanlder

2007-05-29 Thread Jeff Garzik
Jeremy Fitzhardinge wrote: Jeff Garzik wrote: +t3_intr_handler(adapter, qs-rspq.polling) (0, +(adapter-flags USING_MSIX) ? +(void *)qs : (void *)adapter); Remove needless casts to void* The two branches of ?: need to have the same type; without

Re: [PATCH 2/7] cxgb3 - fix netpoll hanlder

2007-05-28 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Fix netpoll handler to work with line interrupt, msi and msi-x. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c | 12 +--- drivers/net/cxgb3/sge.c|1 - 2 files changed, 9

Re: [PATCH 2/7] cxgb3 - fix netpoll hanlder

2007-05-28 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Divy Le Ray [EMAIL PROTECTED] Fix netpoll handler to work with line interrupt, msi and msi-x. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/cxgb3_main.c | 12 +--- drivers/net/cxgb3/sge.c|1 - 2 files changed, 9

[PATCH 2/7] cxgb3 - fix netpoll hanlder

2007-05-26 Thread divy
From: Divy Le Ray <[EMAIL PROTECTED]> Fix netpoll handler to work with line interrupt, msi and msi-x. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c | 12 +--- drivers/net/cxgb3/sge.c|1 - 2 files changed, 9 insertions(+), 4 deletions(-)

[PATCH 2/7] cxgb3 - fix netpoll hanlder

2007-05-26 Thread divy
From: Divy Le Ray [EMAIL PROTECTED] Fix netpoll handler to work with line interrupt, msi and msi-x. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/cxgb3_main.c | 12 +--- drivers/net/cxgb3/sge.c|1 - 2 files changed, 9 insertions(+), 4 deletions(-)