Re: [PATCH 2/7] fs/ext{2,3,4}: Use BUG_ON

2008-02-17 Thread Theodore Tso
On Sun, Feb 17, 2008 at 06:55:06PM +0100, Julia Lawall wrote: > From: Julia Lawall <[EMAIL PROTECTED]> > > if (...) BUG(); should be replaced with BUG_ON(...) when the test has no > side-effects to allow a definition of BUG_ON that drops the code completely. Hi, in the future, please separate ext

[PATCH 2/7] fs/ext{2,3,4}: Use BUG_ON

2008-02-17 Thread Julia Lawall
From: Julia Lawall <[EMAIL PROTECTED]> if (...) BUG(); should be replaced with BUG_ON(...) when the test has no side-effects to allow a definition of BUG_ON that drops the code completely. fs/ext2/balloc.c |3 +-- fs/ext2/dir.c|3 +-- fs/ext3/balloc.c |3 +-- fs/ext4/balloc.c |