Re: [PATCH 2/7] fs/locks: Replace lg_global with a percpu-rwsem

2016-09-06 Thread Peter Zijlstra
On Tue, Sep 06, 2016 at 10:36:01AM +0200, Andreas Mohr wrote: > There might be further archives (other than gmane.org or some such), > however so far lkml.org seemed to be quite ok > and with IMHO better usability than some others Agreed, in that I liked the interface best too, however: > (althou

Re: [PATCH 2/7] fs/locks: Replace lg_global with a percpu-rwsem

2016-09-06 Thread Andreas Mohr
On Tue, Sep 06, 2016 at 10:23:28AM +0200, Peter Zijlstra wrote: > On Tue, Sep 06, 2016 at 03:58:00AM +0200, Andreas Mohr wrote: > > Hi, > > > > [no properly binding reference via In-Reply-To: available thus manually > > re-creating, sorry] > > > > https://lkml.org/lkml/2016/9/5/832 > > Subscrib

Re: [PATCH 2/7] fs/locks: Replace lg_global with a percpu-rwsem

2016-09-06 Thread Peter Zijlstra
On Tue, Sep 06, 2016 at 03:58:00AM +0200, Andreas Mohr wrote: > Hi, > > [no properly binding reference via In-Reply-To: available thus manually > re-creating, sorry] > > https://lkml.org/lkml/2016/9/5/832 Subscribe to lkml already.. also lkml.org is near useless these days, please use any other

Re: [PATCH 2/7] fs/locks: Replace lg_global with a percpu-rwsem

2016-09-05 Thread Andreas Mohr
Hi, [no properly binding reference via In-Reply-To: available thus manually re-creating, sorry] https://lkml.org/lkml/2016/9/5/832 Two thoughts: ***multiple locks Don't have much insight into this (didn't spend much thinking on this), but of course it's unfortunate that two lock types need t

[PATCH 2/7] fs/locks: Replace lg_global with a percpu-rwsem

2016-09-05 Thread Peter Zijlstra
Replace the global part of the lglock with a percpu-rwsem. Since fcl_lock is a spinlock and itself nests under i_lock, which too is a spinlock we cannot acquire sleeping locks at locks_{insert,remove}_global_locks(). We can however wrap all fcl_lock acquisitions with percpu_down_read such that al