Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Tue, 2017-11-21 at 12:48 -0700, Jim Davis wrote: > On Tue, Nov 21, 2017 at 1:10 AM, Knut Omang wrote: > > > Would you like to keep the checkpatch changes in some form, or would you > > rather > > see everything happening in the wrapper? > > I don't have a strong

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Tue, 2017-11-21 at 12:48 -0700, Jim Davis wrote: > On Tue, Nov 21, 2017 at 1:10 AM, Knut Omang wrote: > > > Would you like to keep the checkpatch changes in some form, or would you > > rather > > see everything happening in the wrapper? > > I don't have a strong preference one way or

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Tue, Nov 21, 2017 at 1:10 AM, Knut Omang wrote: > Would you like to keep the checkpatch changes in some form, or would you > rather > see everything happening in the wrapper? I don't have a strong preference one way or another, but keeping everything in a wrapper

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Tue, Nov 21, 2017 at 1:10 AM, Knut Omang wrote: > Would you like to keep the checkpatch changes in some form, or would you > rather > see everything happening in the wrapper? I don't have a strong preference one way or another, but keeping everything in a wrapper script might be easier if

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Mon, 2017-11-20 at 17:00 -0700, Jim Davis wrote: > On Mon, Nov 20, 2017 at 2:22 PM, Luc Van Oostenryck > wrote: > > > Should it be possible to somehow keep the distinction between > > the flags coming from KBUILD_CFLAGS and the pure CHECKFLAGS? > > Well, the

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Mon, 2017-11-20 at 17:00 -0700, Jim Davis wrote: > On Mon, Nov 20, 2017 at 2:22 PM, Luc Van Oostenryck > wrote: > > > Should it be possible to somehow keep the distinction between > > the flags coming from KBUILD_CFLAGS and the pure CHECKFLAGS? > > Well, the practical problem seems to be

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Mon, Nov 20, 2017 at 2:22 PM, Luc Van Oostenryck wrote: > Should it be possible to somehow keep the distinction between > the flags coming from KBUILD_CFLAGS and the pure CHECKFLAGS? Well, the practical problem seems to be that $(CHECK) is called in

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Mon, Nov 20, 2017 at 2:22 PM, Luc Van Oostenryck wrote: > Should it be possible to somehow keep the distinction between > the flags coming from KBUILD_CFLAGS and the pure CHECKFLAGS? Well, the practical problem seems to be that $(CHECK) is called in scripts/Makefile.build with both

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Mon, Nov 20, 2017 at 10:10:12PM +0100, Knut Omang wrote: > On Mon, 2017-11-20 at 21:08 +0100, Luc Van Oostenryck wrote: > > > > It should be noted though that CHECKFLAGS contains very very few > > sparse specific things. It's mainly flags for the compiler > > coming from KBUILD_CFLAGS (which

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Mon, Nov 20, 2017 at 10:10:12PM +0100, Knut Omang wrote: > On Mon, 2017-11-20 at 21:08 +0100, Luc Van Oostenryck wrote: > > > > It should be noted though that CHECKFLAGS contains very very few > > sparse specific things. It's mainly flags for the compiler > > coming from KBUILD_CFLAGS (which

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Mon, 2017-11-20 at 21:08 +0100, Luc Van Oostenryck wrote: > On Mon, Nov 20, 2017 at 12:48:35PM -0700, Jim Davis wrote: > > > > I'd be nice if people could just specify CHECK and CHECKFLAGS to run > > their favorite checker, but currently CHECKFLAGS seems hardwired for > > running sparse. So

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Mon, 2017-11-20 at 21:08 +0100, Luc Van Oostenryck wrote: > On Mon, Nov 20, 2017 at 12:48:35PM -0700, Jim Davis wrote: > > > > I'd be nice if people could just specify CHECK and CHECKFLAGS to run > > their favorite checker, but currently CHECKFLAGS seems hardwired for > > running sparse. So

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Tue, 2017-11-21 at 01:18 +0900, Masahiro Yamada wrote: > 2017-11-17 2:01 GMT+09:00 Knut Omang : > > Add interpretation of a new environment variable P={1,2} in spirit of the > > C= option, but executing checkpatch instead of sparse. > > > > Signed-off-by: Knut Omang

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Tue, 2017-11-21 at 01:18 +0900, Masahiro Yamada wrote: > 2017-11-17 2:01 GMT+09:00 Knut Omang : > > Add interpretation of a new environment variable P={1,2} in spirit of the > > C= option, but executing checkpatch instead of sparse. > > > > Signed-off-by: Knut Omang > > Reviewed-by: Håkon

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Mon, Nov 20, 2017 at 12:48:35PM -0700, Jim Davis wrote: > > I'd be nice if people could just specify CHECK and CHECKFLAGS to run > their favorite checker, but currently CHECKFLAGS seems hardwired for > running sparse. So something liike > > make C=1 CHECK="scripts/checkpatch.pl"

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Mon, Nov 20, 2017 at 12:48:35PM -0700, Jim Davis wrote: > > I'd be nice if people could just specify CHECK and CHECKFLAGS to run > their favorite checker, but currently CHECKFLAGS seems hardwired for > running sparse. So something liike > > make C=1 CHECK="scripts/checkpatch.pl"

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Mon, Nov 20, 2017 at 9:18 AM, Masahiro Yamada wrote: > > I am unhappy about adding a new interface > for each checker. > > The default of CHECK is "sparse", but > users can override it to use another checker. > > > > As Decumentation/dev-tools/coccinelle.rst

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Mon, Nov 20, 2017 at 9:18 AM, Masahiro Yamada wrote: > > I am unhappy about adding a new interface > for each checker. > > The default of CHECK is "sparse", but > users can override it to use another checker. > > > > As Decumentation/dev-tools/coccinelle.rst says, > if you want to use

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

2017-11-17 2:01 GMT+09:00 Knut Omang : > Add interpretation of a new environment variable P={1,2} in spirit of the > C= option, but executing checkpatch instead of sparse. > > Signed-off-by: Knut Omang > Reviewed-by: Håkon Bugge

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

2017-11-17 2:01 GMT+09:00 Knut Omang : > Add interpretation of a new environment variable P={1,2} in spirit of the > C= option, but executing checkpatch instead of sparse. > > Signed-off-by: Knut Omang > Reviewed-by: Håkon Bugge > Acked-by: Åsmund Østvold > --- > Makefile | 20

[PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

Add interpretation of a new environment variable P={1,2} in spirit of the C= option, but executing checkpatch instead of sparse. Signed-off-by: Knut Omang Reviewed-by: Håkon Bugge Acked-by: Åsmund Østvold --- Makefile

[PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

Add interpretation of a new environment variable P={1,2} in spirit of the C= option, but executing checkpatch instead of sparse. Signed-off-by: Knut Omang Reviewed-by: Håkon Bugge Acked-by: Åsmund Østvold --- Makefile | 20 +++- scripts/Makefile.build | 13