Re: [PATCH 2/7] ksm: treat unstable nid like in stable tree

2013-03-07 Thread Ric Mason
Ping Hugh, :-) On 03/06/2013 06:18 PM, Ric Mason wrote: Hi Hugh, On 03/06/2013 01:05 PM, Hugh Dickins wrote: On Wed, 6 Mar 2013, Ric Mason wrote: [ I've deleted the context because that was about the unstable tree, and here you have moved to asking about a case in the stable tree. ] I think

Re: [PATCH 2/7] ksm: treat unstable nid like in stable tree

2013-03-06 Thread Ric Mason
Hi Hugh, On 03/06/2013 01:05 PM, Hugh Dickins wrote: On Wed, 6 Mar 2013, Ric Mason wrote: [ I've deleted the context because that was about the unstable tree, and here you have moved to asking about a case in the stable tree. ] I think I can basically understand you, please correct me if som

Re: [PATCH 2/7] ksm: treat unstable nid like in stable tree

2013-03-05 Thread Ric Mason
Hi Hugh, On 03/06/2013 01:05 PM, Hugh Dickins wrote: On Wed, 6 Mar 2013, Ric Mason wrote: [ I've deleted the context because that was about the unstable tree, and here you have moved to asking about a case in the stable tree. ] For the case of a ksm page is migrated to a different NUMA node a

Re: [PATCH 2/7] ksm: treat unstable nid like in stable tree

2013-03-05 Thread Hugh Dickins
On Wed, 6 Mar 2013, Ric Mason wrote: [ I've deleted the context because that was about the unstable tree, and here you have moved to asking about a case in the stable tree. ] > > For the case of a ksm page is migrated to a different NUMA node and migrate > its stable node to the right tree and

Re: [PATCH 2/7] ksm: treat unstable nid like in stable tree

2013-03-05 Thread Hugh Dickins
On Wed, 6 Mar 2013, Will Huck wrote: > > How ksm treat a ksm forked page? IIUC, it's not merged in ksm stable tree. It > will just be ignore? No, it's there in the stable tree, as it was before it got forked. And when ksmd comes around to find the new mm, it will allocate an rmap_item for that p

Re: [PATCH 2/7] ksm: treat unstable nid like in stable tree

2013-03-05 Thread Ric Mason
On 03/02/2013 10:57 AM, Hugh Dickins wrote: On Sat, 2 Mar 2013, Ric Mason wrote: On 03/02/2013 04:03 AM, Hugh Dickins wrote: On Fri, 1 Mar 2013, Ric Mason wrote: I think the ksm implementation for num awareness is buggy. Sorry, I just don't understand your comments below, but will try to ans

Re: [PATCH 2/7] ksm: treat unstable nid like in stable tree

2013-03-05 Thread Will Huck
Hi Hugh, On 03/02/2013 10:57 AM, Hugh Dickins wrote: How ksm treat a ksm forked page? IIUC, it's not merged in ksm stable tree. It will just be ignore? On Sat, 2 Mar 2013, Ric Mason wrote: On 03/02/2013 04:03 AM, Hugh Dickins wrote: On Fri, 1 Mar 2013, Ric Mason wrote: I think the ksm impl

Re: [PATCH 2/7] ksm: treat unstable nid like in stable tree

2013-03-01 Thread Hugh Dickins
On Sat, 2 Mar 2013, Ric Mason wrote: > On 03/02/2013 04:03 AM, Hugh Dickins wrote: > > On Fri, 1 Mar 2013, Ric Mason wrote: > > > I think the ksm implementation for num awareness is buggy. > > Sorry, I just don't understand your comments below, > > but will try to answer or question them as best I

Re: [PATCH 2/7] ksm: treat unstable nid like in stable tree

2013-03-01 Thread Ric Mason
Hi Hugh, On 03/02/2013 04:03 AM, Hugh Dickins wrote: On Fri, 1 Mar 2013, Ric Mason wrote: I think the ksm implementation for num awareness is buggy. Sorry, I just don't understand your comments below, but will try to answer or question them as best I can. For page migratyion stuff, new page

Re: [PATCH 2/7] ksm: treat unstable nid like in stable tree

2013-03-01 Thread Hugh Dickins
On Fri, 1 Mar 2013, Ric Mason wrote: > > I think the ksm implementation for num awareness is buggy. Sorry, I just don't understand your comments below, but will try to answer or question them as best I can. > > For page migratyion stuff, new page is allocated from node *which page is > migrate

Re: [PATCH 2/7] ksm: treat unstable nid like in stable tree

2013-02-28 Thread Ric Mason
Hi Hugh, On 02/23/2013 05:03 AM, Hugh Dickins wrote: On Fri, 22 Feb 2013, Ric Mason wrote: On 02/21/2013 04:20 PM, Hugh Dickins wrote: An inconsistency emerged in reviewing the NUMA node changes to KSM: when meeting a page from the wrong NUMA node in a stable tree, we say that it's okay for co

Re: [PATCH 2/7] ksm: treat unstable nid like in stable tree

2013-02-22 Thread Hugh Dickins
On Fri, 22 Feb 2013, Ric Mason wrote: > On 02/21/2013 04:20 PM, Hugh Dickins wrote: > > An inconsistency emerged in reviewing the NUMA node changes to KSM: > > when meeting a page from the wrong NUMA node in a stable tree, we say > > that it's okay for comparisons, but not as a leaf for merging; wh

Re: [PATCH 2/7] ksm: treat unstable nid like in stable tree

2013-02-21 Thread Ric Mason
On 02/21/2013 04:20 PM, Hugh Dickins wrote: An inconsistency emerged in reviewing the NUMA node changes to KSM: when meeting a page from the wrong NUMA node in a stable tree, we say that it's okay for comparisons, but not as a leaf for merging; whereas when meeting a page from the wrong NUMA node

[PATCH 2/7] ksm: treat unstable nid like in stable tree

2013-02-21 Thread Hugh Dickins
An inconsistency emerged in reviewing the NUMA node changes to KSM: when meeting a page from the wrong NUMA node in a stable tree, we say that it's okay for comparisons, but not as a leaf for merging; whereas when meeting a page from the wrong NUMA node in an unstable tree, we bail out immediately.