RE: [PATCH 2/7] mmc-utils: treat FIRMWARE_VERSION as binary field instead of string

2018-10-10 Thread Avri Altman
> > On Wed, Oct 10, 2018 at 4:43 AM Avri Altman wrote: > > > > > > > +++ b/mmc_cmds.c > > > @@ -1758,8 +1758,15 @@ int do_read_extcsd(int nargs, char **argv) > > > } > > > > > > if (ext_csd_rev >= 7) { > > > - printf("eMMC Firmware Version: %s\n", > > > -

RE: [PATCH 2/7] mmc-utils: treat FIRMWARE_VERSION as binary field instead of string

2018-10-10 Thread Avri Altman
> > On Wed, Oct 10, 2018 at 4:43 AM Avri Altman wrote: > > > > > > > +++ b/mmc_cmds.c > > > @@ -1758,8 +1758,15 @@ int do_read_extcsd(int nargs, char **argv) > > > } > > > > > > if (ext_csd_rev >= 7) { > > > - printf("eMMC Firmware Version: %s\n", > > > -

Re: [PATCH 2/7] mmc-utils: treat FIRMWARE_VERSION as binary field instead of string

2018-10-10 Thread James Nuss
On Wed, Oct 10, 2018 at 4:43 AM Avri Altman wrote: > > > > +++ b/mmc_cmds.c > > @@ -1758,8 +1758,15 @@ int do_read_extcsd(int nargs, char **argv) > > } > > > > if (ext_csd_rev >= 7) { > > - printf("eMMC Firmware Version: %s\n", > > -

Re: [PATCH 2/7] mmc-utils: treat FIRMWARE_VERSION as binary field instead of string

2018-10-10 Thread James Nuss
On Wed, Oct 10, 2018 at 4:43 AM Avri Altman wrote: > > > > +++ b/mmc_cmds.c > > @@ -1758,8 +1758,15 @@ int do_read_extcsd(int nargs, char **argv) > > } > > > > if (ext_csd_rev >= 7) { > > - printf("eMMC Firmware Version: %s\n", > > -

RE: [PATCH 2/7] mmc-utils: treat FIRMWARE_VERSION as binary field instead of string

2018-10-10 Thread Avri Altman
> +++ b/mmc_cmds.c > @@ -1758,8 +1758,15 @@ int do_read_extcsd(int nargs, char **argv) > } > > if (ext_csd_rev >= 7) { > - printf("eMMC Firmware Version: %s\n", > - (char*)_csd[EXT_CSD_FIRMWARE_VERSION]); > + printf("Firmware Version: >

RE: [PATCH 2/7] mmc-utils: treat FIRMWARE_VERSION as binary field instead of string

2018-10-10 Thread Avri Altman
> +++ b/mmc_cmds.c > @@ -1758,8 +1758,15 @@ int do_read_extcsd(int nargs, char **argv) > } > > if (ext_csd_rev >= 7) { > - printf("eMMC Firmware Version: %s\n", > - (char*)_csd[EXT_CSD_FIRMWARE_VERSION]); > + printf("Firmware Version: >

[PATCH 2/7] mmc-utils: treat FIRMWARE_VERSION as binary field instead of string

2018-10-09 Thread James Nuss
The FIRMWARE_VERSION field is 8-bytes in size and contains non-printable characters. Treat this field as binary and print individual byte values in hex Signed-off-by: James Nuss --- mmc.h | 9 - mmc_cmds.c | 11 +-- 2 files changed, 17 insertions(+), 3 deletions(-) diff

[PATCH 2/7] mmc-utils: treat FIRMWARE_VERSION as binary field instead of string

2018-10-09 Thread James Nuss
The FIRMWARE_VERSION field is 8-bytes in size and contains non-printable characters. Treat this field as binary and print individual byte values in hex Signed-off-by: James Nuss --- mmc.h | 9 - mmc_cmds.c | 11 +-- 2 files changed, 17 insertions(+), 3 deletions(-) diff