Re: [PATCH 2/7] net: batman-adv: remove unneeded MODULE_VERSION() usage

2020-12-08 Thread Sven Eckelmann
On Tuesday, 8 December 2020 08:48:56 CET Enrico Weigelt, metux IT consult wrote: > > Is there some explanation besides an opinion? Some kind goal which you want > > to > > achieve with it maybe? > > Just a cleanup. I've been under the impression that this version is just > an relic from oot

Re: [PATCH 2/7] net: batman-adv: remove unneeded MODULE_VERSION() usage

2020-12-07 Thread Enrico Weigelt, metux IT consult
On 05.12.20 08:06, Sven Eckelmann wrote: Hi, > Is there some explanation besides an opinion? Some kind goal which you want > to > achieve with it maybe? Just a cleanup. I've been under the impression that this version is just an relic from oot times. > At least for us it was an easy way to

Re: [PATCH 2/7] net: batman-adv: remove unneeded MODULE_VERSION() usage

2020-12-05 Thread Jakub Kicinski
On Sat, 05 Dec 2020 08:06:40 +0100 Sven Eckelmann wrote: > On Wednesday, 2 December 2020 13:49:54 CET Enrico Weigelt, metux IT consult > wrote: > > Remove MODULE_VERSION(), as it isn't needed at all: the only version > > making sense is the kernel version. > > Is there some explanation besides

Re: [PATCH 2/7] net: batman-adv: remove unneeded MODULE_VERSION() usage

2020-12-04 Thread Sven Eckelmann
On Wednesday, 2 December 2020 13:49:54 CET Enrico Weigelt, metux IT consult wrote: > Remove MODULE_VERSION(), as it isn't needed at all: the only version > making sense is the kernel version. Is there some explanation besides an opinion? Some kind goal which you want to achieve with it maybe?

[PATCH 2/7] net: batman-adv: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult --- net/batman-adv/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c index