Re: [PATCH 2/7] staging: unisys: move uislib/platform proc entry to debugfs

2014-05-20 Thread Romer, Benjamin M
On Tue, 2014-05-20 at 10:09 +0900, Greg KH wrote: > On Mon, May 19, 2014 at 10:57:08PM +0300, Dan Carpenter wrote: > > On Mon, May 19, 2014 at 09:42:22AM -0500, Romer, Benjamin M wrote: > > > On Sun, 2014-05-18 at 09:49 -0700, Greg KH wrote: > > > > Also, why are these entries moving to debugfs at

Re: [PATCH 2/7] staging: unisys: move uislib/platform proc entry to debugfs

2014-05-19 Thread Greg KH
On Mon, May 19, 2014 at 10:57:08PM +0300, Dan Carpenter wrote: > On Mon, May 19, 2014 at 09:42:22AM -0500, Romer, Benjamin M wrote: > > On Sun, 2014-05-18 at 09:49 -0700, Greg KH wrote: > > > Also, why are these entries moving to debugfs at all? Why are they > > > needed? Who will use them? Are

Re: [PATCH 2/7] staging: unisys: move uislib/platform proc entry to debugfs

2014-05-19 Thread Dan Carpenter
On Mon, May 19, 2014 at 09:42:22AM -0500, Romer, Benjamin M wrote: > On Sun, 2014-05-18 at 09:49 -0700, Greg KH wrote: > > Also, why are these entries moving to debugfs at all? Why are they > > needed? Who will use them? Are tools relying on them to be there? > > The tuning entries are sometime

Re: [PATCH 2/7] staging: unisys: move uislib/platform proc entry to debugfs

2014-05-19 Thread Romer, Benjamin M
On Sun, 2014-05-18 at 09:49 -0700, Greg KH wrote: > There's no need to keep this dentry around, you can just remove all the > debugfs files in your directory recursively when you exit. That will > save you code and logic overall. Ah, thanks! I wasn't aware that I could do that. That's an easy fix

Re: [PATCH 2/7] staging: unisys: move uislib/platform proc entry to debugfs

2014-05-18 Thread Greg KH
On Mon, May 12, 2014 at 12:38:30PM -0400, Benjamin Romer wrote: > Convert /proc/uislib/platform to an equivalent entry in debugfs. > > Signed-off-by: Benjamin Romer > --- > drivers/staging/unisys/uislib/uislib.c | 62 > ++ > 1 file changed, 17 insertions(+), 45 d

[PATCH 2/7] staging: unisys: move uislib/platform proc entry to debugfs

2014-05-12 Thread Benjamin Romer
Convert /proc/uislib/platform to an equivalent entry in debugfs. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/uislib/uislib.c | 62 ++ 1 file changed, 17 insertions(+), 45 deletions(-) diff --git a/drivers/staging/unisys/uislib/uislib.c b/drivers/sta