Re: [PATCH 2/7] uprobes: Fold xol_alloc_area() into get_xol_area()

2013-01-09 Thread Oleg Nesterov
On 01/09, Anton Arapov wrote: > > On Mon, Dec 31, 2012 at 06:52:16PM +0100, Oleg Nesterov wrote: > > + * get_alloc_area - Allocate process's xol_area if necessary. > > + * This area will be used for storing instructions for execution out of > > line. > > * > > * Returns the allocated area or

Re: [PATCH 2/7] uprobes: Fold xol_alloc_area() into get_xol_area()

2013-01-09 Thread Anton Arapov
On Mon, Dec 31, 2012 at 06:52:16PM +0100, Oleg Nesterov wrote: > Currently only xol_get_insn_slot() does get_xol_area() + xol_alloc_area(), > but this will have more users and we do not want to copy-and-paste this > code. This patch simply moves xol_alloc_area() into get_xol_area() to > simplify

Re: [PATCH 2/7] uprobes: Fold xol_alloc_area() into get_xol_area()

2013-01-09 Thread Anton Arapov
On Mon, Dec 31, 2012 at 06:52:16PM +0100, Oleg Nesterov wrote: Currently only xol_get_insn_slot() does get_xol_area() + xol_alloc_area(), but this will have more users and we do not want to copy-and-paste this code. This patch simply moves xol_alloc_area() into get_xol_area() to simplify the

Re: [PATCH 2/7] uprobes: Fold xol_alloc_area() into get_xol_area()

2013-01-09 Thread Oleg Nesterov
On 01/09, Anton Arapov wrote: On Mon, Dec 31, 2012 at 06:52:16PM +0100, Oleg Nesterov wrote: + * get_alloc_area - Allocate process's xol_area if necessary. + * This area will be used for storing instructions for execution out of line. * * Returns the allocated area or NULL. */

Re: [PATCH 2/7] uprobes: Fold xol_alloc_area() into get_xol_area()

2013-01-08 Thread Srikar Dronamraju
* Oleg Nesterov [2012-12-31 18:52:16]: > Currently only xol_get_insn_slot() does get_xol_area() + xol_alloc_area(), > but this will have more users and we do not want to copy-and-paste this > code. This patch simply moves xol_alloc_area() into get_xol_area() to > simplify the current and future

Re: [PATCH 2/7] uprobes: Fold xol_alloc_area() into get_xol_area()

2013-01-08 Thread Srikar Dronamraju
* Oleg Nesterov o...@redhat.com [2012-12-31 18:52:16]: Currently only xol_get_insn_slot() does get_xol_area() + xol_alloc_area(), but this will have more users and we do not want to copy-and-paste this code. This patch simply moves xol_alloc_area() into get_xol_area() to simplify the current

[PATCH 2/7] uprobes: Fold xol_alloc_area() into get_xol_area()

2012-12-31 Thread Oleg Nesterov
Currently only xol_get_insn_slot() does get_xol_area() + xol_alloc_area(), but this will have more users and we do not want to copy-and-paste this code. This patch simply moves xol_alloc_area() into get_xol_area() to simplify the current and future code. Signed-off-by: Oleg Nesterov ---

[PATCH 2/7] uprobes: Fold xol_alloc_area() into get_xol_area()

2012-12-31 Thread Oleg Nesterov
Currently only xol_get_insn_slot() does get_xol_area() + xol_alloc_area(), but this will have more users and we do not want to copy-and-paste this code. This patch simply moves xol_alloc_area() into get_xol_area() to simplify the current and future code. Signed-off-by: Oleg Nesterov