Re: [PATCH 2/7] xen: introduce the header file for the Xen 9pfs transport protocol

2017-03-06 Thread Boris Ostrovsky
> +struct xen_9pfs_header { > + uint32_t size; > + uint8_t id; > + uint16_t tag; I realize that this is in the spec now and it's probably too late to ask this question but wouldn't it be better if id and tag were swapped? No need to pack and potentially faster access to tag. -boris

Re: [PATCH 2/7] xen: introduce the header file for the Xen 9pfs transport protocol

2017-03-06 Thread Boris Ostrovsky
On 03/06/2017 04:36 PM, Stefano Stabellini wrote: > On Mon, 6 Mar 2017, Boris Ostrovsky wrote: >>> + uint32_t size; >>> + uint8_t id; >>> + uint16_t tag; >> I realize that this is in the spec now and it's probably too late to ask >> this question but wouldn't it be better if id and tag were s

Re: [PATCH 2/7] xen: introduce the header file for the Xen 9pfs transport protocol

2017-03-06 Thread Stefano Stabellini
On Mon, 6 Mar 2017, Boris Ostrovsky wrote: > > + uint32_t size; > > + uint8_t id; > > + uint16_t tag; > > I realize that this is in the spec now and it's probably too late to ask > this question but wouldn't it be better if id and tag were swapped? No > need to pack and potentially faster ac

[PATCH 2/7] xen: introduce the header file for the Xen 9pfs transport protocol

2017-03-06 Thread Stefano Stabellini
It uses the new ring.h macros to declare rings and interfaces. Signed-off-by: Stefano Stabellini CC: konrad.w...@oracle.com CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- include/xen/interface/io/9pfs.h | 40 1 file changed, 40 insertions(+) crea